Skip to content

Example #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Konstantin8105 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Example #16

Konstantin8105 wants to merge 3 commits into from

Conversation

@Konstantin8105
Copy link
Contributor

@Konstantin8105 Konstantin8105 commented May 6, 2018

Fix #13
dmitshur
dmitshur reviewed May 7, 2018
View reviewed changes
Copy link
Member

@dmitshur dmitshur left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The directory should be named example, not examples, per https://dmitri.shuralyov.com/idiomatic-go#use-singular-form-for-collection-repo-folder-name.

Note that I don't have write permissions for this repository, so someone else will need to do final review and merge. I think @ajhager owns this repository, you should check with him whether it's supported.
examples/Simple2D/webgl.go Outdated
vertCode := `attribute vec2 coordinates;` +
`void main(void) {` + ` gl_Position = vec4(coordinates,0.0, 1.0);` + `}`

//Create a vertex shader object
Copy link
Member

@dmitshur dmitshur May 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments should be consistent and use a space after //, like above.

Here, and below.

Reference: https://dmitri.shuralyov.com/idiomatic-go#comments-for-humans-always-have-a-single-space-after-the-slashes.
Copy link
Contributor Author

@Konstantin8105 Konstantin8105 May 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your comment. I will wait @ajhager comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@Konstantin8105 @dmitshur