Skip to content

chore: partial revert of #1297#1298

Merged
parthea merged 5 commits intomainfrom
parthea-patch-2
Nov 6, 2024
Merged

chore: partial revert of #1297#1298
parthea merged 5 commits intomainfrom
parthea-patch-2

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Nov 6, 2024

#1297 included an incorrect change in setup.py that was missed during code review.

The following error appears without the fix in this PR

python-pubsub# pip install .
Processing /python-pubsub
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error
  
  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [1 lines of output]
      error in google-cloud-pubsub setup command: 'extras_require' must be a dictionary whose values are strings or lists of strings containing valid project/version requirement specifiers.
      [end of output]
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/python-pubsub API. labels Nov 6, 2024
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 6, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 6, 2024
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 6, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 6, 2024
@ohmayr
Copy link
Contributor

ohmayr commented Nov 6, 2024

I suspect the pip command to fail without the extra.

@parthea parthea marked this pull request as ready for review November 6, 2024 21:20
@parthea parthea requested a review from a team as a code owner November 6, 2024 21:20
@parthea parthea requested a review from a team November 6, 2024 21:20
@parthea parthea enabled auto-merge (squash) November 6, 2024 21:20
@parthea parthea merged commit 347cb38 into main Nov 6, 2024
@parthea parthea deleted the parthea-patch-2 branch November 6, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. size: xs Pull request size is extra small.

3 participants