Skip to content

test: Silence return_immediately flag Deprecation Warning#1066

Merged
parthea merged 2 commits intomainfrom
silenceWarning
Feb 2, 2024
Merged

test: Silence return_immediately flag Deprecation Warning#1066
parthea merged 2 commits intomainfrom
silenceWarning

Conversation

@mukund-ananthu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@mukund-ananthu mukund-ananthu requested a review from a team as a code owner January 29, 2024 20:26
@mukund-ananthu mukund-ananthu requested a review from a team January 29, 2024 20:26
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 29, 2024
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Jan 29, 2024
@mukund-ananthu mukund-ananthu force-pushed the silenceWarning branch 2 times, most recently from 42fa3ba to 03e8ace Compare January 29, 2024 21:03
* Warning currently blocks #1064
* Silencing warning since it is expected
* Warning considered safe to ignore since tests are working as intended
@mukund-ananthu mukund-ananthu changed the title Silence Deprecation Warning Feb 2, 2024
@parthea parthea merged commit b4442c6 into main Feb 2, 2024
@parthea parthea deleted the silenceWarning branch February 2, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. size: xs Pull request size is extra small.

3 participants