Skip to content

docs(samples): correct type and description of timeout parameter in subscriber quickstart #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mukund-ananthu merged 7 commits into from
Mar 5, 2024
Merged

docs(samples): correct type and description of timeout parameter in subscriber quickstart #1051

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8311d7e
Fix type and description of `timeout` parameter in subscriber quickstart
pradn Dec 13, 2023
48ebc7f
Merge branch 'main' into argfix2
pradn Dec 18, 2023
77f839a
Merge branch 'main' into argfix2
mukund-ananthu Feb 7, 2024
47acb71
Merge branch 'main' into argfix2
mukund-ananthu Feb 21, 2024
a84afaf
Merge branch 'main' into argfix2
hongalex Feb 22, 2024
42cbfb9
Merge branch 'main' into argfix2
mukund-ananthu Mar 5, 2024
dfe36b5
Merge branch 'main' into argfix2
mukund-ananthu Mar 5, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samples/snippets/quickstart/sub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def callback(message: pubsub_v1.subscriber.message.Message) -> None:
parser.add_argument("project_id", help="Google Cloud project ID")
parser.add_argument("subscription_id", help="Pub/Sub subscription ID")
parser.add_argument(
"timeout", default=None, nargs="?", const=1, help="Pub/Sub subscription ID"
"timeout", default=None, type=float, nargs="?", const=1, help="StreamingPull timeout in seconds"
)

args = parser.parse_args()
Expand Down