Skip to content

docs: clarify the limitation message associated with the bucket signed URLs #2412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2024
Merged

docs: clarify the limitation message associated with the bucket signed URLs #2412

merged 1 commit into from
Feb 27, 2024

Conversation

@starsandskies
Copy link
Contributor

@starsandskies starsandskies commented Feb 27, 2024

Fixes #2411 🦕
@starsandskies starsandskies requested review from a team as code owners February 27, 2024 22:36
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/nodejs-storage API. labels Feb 27, 2024
@ddelgrosso1
Copy link
Contributor

ddelgrosso1 commented Feb 27, 2024

Only comment is re: the commit message. It needs to adhere to the format docs: clarify the limitation message associated with the bucket signed URLs
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 27, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 27, 2024
@ddelgrosso1 ddelgrosso1 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 27, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 27, 2024
@starsandskies starsandskies changed the title Clarify the limitation message associated with bucket signed URLs Feb 27, 2024
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Feb 27, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/
@starsandskies
Copy link
Contributor Author

starsandskies commented Feb 27, 2024 •
edited
Loading

Updated the commit message in what I'm hoping is the correct manner!

Edit: I'm guessing not, based on the automated message :-P
@ddelgrosso1 ddelgrosso1 added the automerge Merge the pull request once unit tests and other checks pass. label Feb 27, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 153cc00 into googleapis:main Feb 27, 2024
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/nodejs-storage API. kokoro:force-run Add this label to force Kokoro to re-run the tests. size: xs Pull request size is extra small.

2 participants

@starsandskies @ddelgrosso1