-
Notifications
You must be signed in to change notification settings - Fork 62
Closed
Labels
api: bigtableIssues related to the googleapis/nodejs-bigtable API.Issues related to the googleapis/nodejs-bigtable API.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
In the current implementation of createReadStream in table.ts, the end user is supposed to stop the streaming synchronously by calling readStream.end(). If they instead call it asynchronously, setTimeout(() => { readStream.end(); }, 0);, a few records (16 to be precise, that's the default value of highWaterMark for object streams) will still be received.
See the skipped test should be able to stop reading from the read stream when reading asynchronously:
nodejs-bigtable/test/readrows.ts
Line 226 in 5c7c5ae
| it.skip('should be able to stop reading from the read stream when reading asynchronously', function (done) { |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
api: bigtableIssues related to the googleapis/nodejs-bigtable API.Issues related to the googleapis/nodejs-bigtable API.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.