Skip to content
This repository was archived by the owner on Sep 27, 2023. It is now read-only.
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

Shall we delete the tests in the sample directory? #651

Closed
#673
Closed
Shall we delete the tests in the sample directory?#651
#673
Labels
api: jobsIssues related to the googleapis/java-talent API.priority: p2Moderately-important priority. Fix may not be included in next release.samplesIssues that are directly related to samples.

Description

@suztomo
suztomo
opened on Oct 11, 2021

It seems that java-docs-samples also has the same set of the test files as the sample directory of this repository. The sample tests do not work (#648).

image

Shall we delete the files in this repository's sample directory in favor of java-docs-samples?

Activity

  1. product-auto-label
    added
    api: jobsIssues related to the googleapis/java-talent API.
    samplesIssues that are directly related to samples.
    on Oct 11, 2021
  2. suztomo
    added
    priority: p2Moderately-important priority. Fix may not be included in next release.
    on Oct 13, 2021

  3. suztomo commented on Oct 13, 2021

    @suztomo
    suztomo
    on Oct 13, 2021
    MemberAuthor

    It turned out that we should keep the samples in the individual repos.

  4. gcf-merge-on-green
    closed this as completedin #673on Nov 13, 2021
  5. gcf-merge-on-green
    added a commit that references this issue on Nov 13, 2021

    fix(samples): Move to java-docs-samples-testing (#673)

    1bfd919
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    api: jobsIssues related to the googleapis/java-talent API.priority: p2Moderately-important priority. Fix may not be included in next release.samplesIssues that are directly related to samples.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions