feat: Exceptions for Chunked Downloads and Precondition Failure tests - #2062
Merged
Merged
Conversation
product-auto-label
Bot
added
size: m
BenWhitehead
approved these changes
Jun 13, 2023
BenWhitehead
left a comment
BenWhitehead
left a comment
Collaborator
There was a problem hiding this comment.
One additional failure case, but looks good otherwise.
| ByteStreams.copy(rc, wc); | ||
| } catch (IOException e) { | ||
| throw new StorageException(e); | ||
| bytesCopied = ByteStreams.copy(rc, wc); |
Collaborator
There was a problem hiding this comment.
Since we know how many bytes we expect we should validate we receive them here.
There are circumstances where we've seen a connection get truncated without throwing an error, and are not retried.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plumbing of exceptions for chunked downloads and snuck in a standard precondition failure test without skipIfExists set to true.