Skip to content

feat: Implement chunkedDownload and refactor direct downloads. - #1990

Merged
sydney-munro merged 9 commits into
feat/transfer-managerfrom
chunking
May 4, 2023
Merged

feat: Implement chunkedDownload and refactor direct downloads.#1990
sydney-munro merged 9 commits into
feat/transfer-managerfrom
chunking

Conversation

@sydney-munro

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@sydney-munro
sydney-munro requested a review from a team April 20, 2023 16:44
@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: storage Issues related to the googleapis/java-storage API. labels Apr 20, 2023

@BenWhitehead BenWhitehead left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

After merging this branch, can you also merge main up to feat/transfer-manager it's been a bit since we sync'd.

@sydney-munro
sydney-munro merged commit b99a67d into feat/transfer-manager May 4, 2023
@sydney-munro
sydney-munro deleted the chunking branch May 4, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/java-storage API. size: l Pull request size is large.

2 participants