Skip to content

test: introduce BaseConvertablePropertyTest - #1395

Merged
BenWhitehead merged 1 commit into
feat/grpc-storagefrom
base-prop-test
May 17, 2022
Merged

test: introduce BaseConvertablePropertyTest#1395
BenWhitehead merged 1 commit into
feat/grpc-storagefrom
base-prop-test

Conversation

@BenWhitehead

Copy link
Copy Markdown
Collaborator

All Convertable types share a common set of properties that they need to provide. This new class will ensure in a central location they do.

First property: a round trip through the codec should provide a value equal to the initial input

All Convertable types share a common set of properties that they need to provide. This new class will ensure in a central location they do.

First property: a round trip through the codec should provide a value equal to the initial input
@BenWhitehead
BenWhitehead requested a review from a team May 16, 2022 22:52
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage API. labels May 16, 2022

@sydney-munro sydney-munro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenWhitehead
BenWhitehead merged commit 0e923a5 into feat/grpc-storage May 17, 2022
@BenWhitehead
BenWhitehead deleted the base-prop-test branch May 17, 2022 22:09
sydney-munro pushed a commit that referenced this pull request Jun 7, 2022
All Convertable types share a common set of properties that they need to provide. This new class will ensure in a central location they do.

First property: a round trip through the codec should provide a value equal to the initial input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/java-storage API. size: m Pull request size is medium.

2 participants