chore: add crc32c combine utility - #1376
Merged
Merged
Conversation
product-auto-label
Bot
added
size: m
product-auto-label
Bot
added
size: l
BenWhitehead
requested changes
May 5, 2022
BenWhitehead
left a comment
BenWhitehead
left a comment
Collaborator
There was a problem hiding this comment.
A few minor things to clean up, after that it should be ready to merge.
Additionally, can you retarget this PR to feat/grpc-storage instead of main?
Comment on lines
+286
to
+289
| /* | ||
| There is a more efficient implementation in https://github.com/google/crc32c, however for brevity we are following | ||
| the byte by byte computation, implemented in: https://github.com/google/crc32c/blob/main/src/crc32c_portable.cc#L252-L257 | ||
| */ |
Collaborator
There was a problem hiding this comment.
Lets replace this with an actual javadoc comment for the method.
/**
* Straight forward implementation to concatenate ...
* @param crc1
* @param crc2
* @param crc2ObjectSize
* @return
* @see <a target="_blank" rel="noopener noreferrer" href="https://github.com/google/crc32c/blob/main/src/crc32c_portable.cc#L252-L257">https://github.com/google/crc32c/blob/main/src/crc32c_portable.cc#L252-L257</a>
*/
We can also link to the actual code from the javadoc comment and it will be turned into a clickable link rather than simply text.
Comment on lines
+22
to
+24
| /* | ||
| Implementation borrowed taken from: https://github.com/google/crc32c/blob/main/src/crc32c_portable.cc#L16-L59 | ||
| */ |
Collaborator
There was a problem hiding this comment.
Can we javadoc this comment similar to the method?
Also, for all links to github we should link to the SHA of the code rather than main so the link is stable and the line numbers are known.
Collaborator
There was a problem hiding this comment.
Also probably some phrasing like "Ported from ..." instead of "borrowed/taken"
…c32cUtility.java Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
BenWhitehead
approved these changes
May 5, 2022
BenWhitehead
left a comment
BenWhitehead
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the cleanup!
Two more recommendations for git links. After that feel free to merge.
…c32cUtility.java Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
…c32cUtility.java Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
frankyn
added
the
automerge
BenWhitehead
removed
the
automerge
sydney-munro
pushed a commit
that referenced
this pull request
Jun 7, 2022
Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: