Skip to content

test: clean up CookieHolderTest#2361

Merged
mutianf merged 5 commits intomainfrom
cookie-test
Sep 27, 2024
Merged

test: clean up CookieHolderTest#2361
mutianf merged 5 commits intomainfrom
cookie-test

Conversation

@igorbernstein2
Copy link
Contributor

@igorbernstein2 igorbernstein2 commented Sep 27, 2024

  • stop returning protos to trigger headers
  • fix thread safety for variables that are accessed by multiple threads

Change-Id: Ib34440d2ffeddcb5611b5e1cee183004bafc9449

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.
@igorbernstein2
test: clean up CookieHolderTest
67e5899 
- stop returning protos to trigger headers
- fix thread safety for variables that are accessed by multiple threads

Change-Id: Ib34440d2ffeddcb5611b5e1cee183004bafc9449
@igorbernstein2 igorbernstein2 requested review from a team September 27, 2024 17:44
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Sep 27, 2024
@igorbernstein2
missing import
5c3bde3 
Change-Id: Ied61bc081c3cc0220fd96051aabd1849cbffd10f
@igorbernstein2
one more
79c5eae 
Change-Id: Ibf2f4ad8bea038390b1ddf099c3061f0d9b02495
@igorbernstein2
fix broken test
be7e931 
Change-Id: I63a6e54829ef5ea2db8d3b3b2db0afdc89cc1248
@igorbernstein2
make it consistent with other tests
a08a67b 
Change-Id: I2296b1cb7f52895a59e6b4fe5586d07c0dfd97a2
@mutianf mutianf merged commit 29b23d7 into main Sep 27, 2024
@mutianf mutianf deleted the cookie-test branch September 27, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: s Pull request size is small.

2 participants

@igorbernstein2 @mutianf