Skip to content

fix: remove grpclb#2033

Merged
igorbernstein2 merged 8 commits intogoogleapis:mainfrom
mohanli-ml:remove-grpclb
Jun 25, 2024
Merged

fix: remove grpclb#2033
igorbernstein2 merged 8 commits intogoogleapis:mainfrom
mohanli-ml:remove-grpclb

Conversation

@mohanli-ml
Copy link
Contributor

@mohanli-ml mohanli-ml commented Dec 18, 2023

Remove attempt DirectPath gRPCLB by default in CBT Java because:

  1. gRPCLB is being deprecated, and CBT has removed all the gRPCLB traffic back to CloudPath;
  2. Attempt gRPCLB by default has known DNS amplifying issue, all: DNS request amplification with default settings google-cloud-go#7812.
@mohanli-ml mohanli-ml requested a review from a team December 18, 2023 21:34
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Dec 18, 2023
@mutianf mutianf added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Jan 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2024
@gcf-merge-on-green
Copy link

gcf-merge-on-green bot commented Jan 5, 2024

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 5, 2024
@mohanli-ml
Copy link
Contributor Author

mohanli-ml commented Apr 17, 2024

Friendly ping. Can we merge this PR? Golang has merged googleapis/google-cloud-go#9186 so I want to make sure Java and Go has the same behavior. Thanks!
@mohanli-ml mohanli-ml requested review from a team April 18, 2024 20:23
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Apr 18, 2024
igorbernstein2
igorbernstein2 requested changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please remove this line:
https://github.com/googleapis/java-bigtable/blob/main/google-cloud-bigtable/pom.xml#L714
@mohanli-ml
Copy link
Contributor Author

mohanli-ml commented Apr 19, 2024

Also, please remove this line: https://github.com/googleapis/java-bigtable/blob/main/google-cloud-bigtable/pom.xml#L714

Done. Thanks Igor!
@igorbernstein2 igorbernstein2 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 11, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 11, 2024
@igorbernstein2 igorbernstein2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels May 11, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 11, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 11, 2024
@gcf-merge-on-green
Copy link

gcf-merge-on-green bot commented May 11, 2024

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 11, 2024
@igorbernstein2 igorbernstein2 mentioned this pull request Jun 24, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Jun 24, 2024
@igorbernstein2
test: ensure that directpath is enabled for direct path tests (#2263)
bc81478 
This should unblock #2033 which disables directpath by default
@igorbernstein2 igorbernstein2 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 24, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 24, 2024
@igorbernstein2 igorbernstein2 merged commit 7355375 into googleapis:main Jun 25, 2024
@igorbernstein2 igorbernstein2 mentioned this pull request Jun 25, 2024
Closed
@release-please release-please bot mentioned this pull request Jun 25, 2024
Merged
ron-gal pushed a commit to ron-gal/java-bigtable that referenced this pull request Jul 23, 2024
@igorbernstein2 @ron-gal
test: ensure that directpath is enabled for direct path tests (google…
cbac324 
…apis#2263)

This should unblock googleapis#2033 which disables directpath by default
ron-gal pushed a commit to ron-gal/java-bigtable that referenced this pull request Jul 23, 2024
@mohanli-ml @gcf-owl-bot
@igorbernstein2 @ron-gal
fix: remove grpclb (googleapis#2033)
cdb83ce 
* fix: remove grpclb

* fix: remove grpclb

* fix: remove grpclb

* fix: remove grpclb

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Igor Bernstein <igorbernstein@google.com>
lqiu96 pushed a commit that referenced this pull request Jul 26, 2024
@mohanli-ml @gcf-owl-bot
@igorbernstein2 @lqiu96
fix: remove grpclb (#2033)
f2889ce 
* fix: remove grpclb

* fix: remove grpclb

* fix: remove grpclb

* fix: remove grpclb

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Igor Bernstein <igorbernstein@google.com>
@release-please release-please bot mentioned this pull request Dec 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. kokoro:force-run Add this label to force Kokoro to re-run the tests. size: s Pull request size is small.

4 participants

@mohanli-ml @igorbernstein2 @mutianf @yoshi-kokoro