Skip to content

feat: Add APIs to enable request priorities#1959

Merged
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:mainfrom
DerekLeeCS:request-priorities
Oct 26, 2023
Merged

feat: Add APIs to enable request priorities#1959
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:mainfrom
DerekLeeCS:request-priorities

Conversation

@DerekLeeCS
Copy link
Contributor

@DerekLeeCS DerekLeeCS commented Oct 16, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.
@DerekLeeCS DerekLeeCS requested a review from a team October 16, 2023 20:43
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigtable Issues related to the googleapis/java-bigtable API. labels Oct 16, 2023
igorbernstein2
igorbernstein2 requested changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, I added a few comments and I this needs a couple of integration tests
@igorbernstein2 igorbernstein2 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 25, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team October 25, 2023 16:53
@gcf-merge-on-green
Copy link

gcf-merge-on-green bot commented Oct 25, 2023

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 25, 2023
@mutianf mutianf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2023
@mutianf mutianf added the automerge Merge the pull request once unit tests and other checks pass. label Oct 26, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit befd140 into googleapis:main Oct 26, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 26, 2023
@release-please release-please bot mentioned this pull request Oct 26, 2023
Merged
@DerekLeeCS DerekLeeCS deleted the request-priorities branch October 26, 2023 15:21
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 26, 2023
@release-please
chore(main): release 2.29.0 (#1969)
ffbf49a 
🤖 I have created a release *beep* *boop*
---


## [2.29.0](https://togithub.com/googleapis/java-bigtable/compare/v2.28.0...v2.29.0) (2023-10-26)


### Features

* Add APIs to enable request priorities ([#1959](https://togithub.com/googleapis/java-bigtable/issues/1959)) ([befd140](https://togithub.com/googleapis/java-bigtable/commit/befd1402a0f324b365b72e3b237d33d2f3fe8bbc))


### Dependencies

* Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.28 ([#1966](https://togithub.com/googleapis/java-bigtable/issues/1966)) ([8fb09e5](https://togithub.com/googleapis/java-bigtable/commit/8fb09e53a3d85273578ba26c522931047b249333))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.28 ([#1967](https://togithub.com/googleapis/java-bigtable/issues/1967)) ([117e0ec](https://togithub.com/googleapis/java-bigtable/commit/117e0ec546343798cbc69eb23fef539de0b8bb8d))
* Update shared dependencies ([#1964](https://togithub.com/googleapis/java-bigtable/issues/1964)) ([bf5a9b7](https://togithub.com/googleapis/java-bigtable/commit/bf5a9b774f79005ee9980a12931597ddc1ec5bb3))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: l Pull request size is large.

4 participants

@DerekLeeCS @igorbernstein2 @mutianf @yoshi-kokoro