Skip to content

feat: Support AuthorizedView in bigtable data client #2177

Merged
igorbernstein2 merged 3 commits intogoogleapis:mainfrom
trollyxia:authorized_view_data
Mar 27, 2024
Merged

feat: Support AuthorizedView in bigtable data client #2177
igorbernstein2 merged 3 commits intogoogleapis:mainfrom
trollyxia:authorized_view_data

Conversation

@trollyxia
Copy link
Member

@trollyxia trollyxia commented Mar 20, 2024

IMPORTANT: This PR includes data client changes only, and should be merged after #2175.
@trollyxia trollyxia requested review from a team March 20, 2024 20:11
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigtable Issues related to the googleapis/java-bigtable API. labels Mar 20, 2024
@trollyxia trollyxia force-pushed the authorized_view_data branch from 0d2c752 to 3287381 Compare March 20, 2024 20:53
mutianf
mutianf suggested changes Mar 20, 2024
View reviewed changes
mutianf
mutianf reviewed Mar 22, 2024
View reviewed changes
igorbernstein2
igorbernstein2 requested changes Mar 27, 2024
View reviewed changes
@trollyxia trollyxia force-pushed the authorized_view_data branch from 60365af to 9592a9e Compare March 27, 2024 18:16
@trollyxia trollyxia requested a review from a team March 27, 2024 18:16
mutianf
mutianf reviewed Mar 27, 2024
View reviewed changes
@trollyxia trollyxia force-pushed the authorized_view_data branch from 9592a9e to e5562af Compare March 27, 2024 19:41
mutianf
mutianf reviewed Mar 27, 2024
View reviewed changes
google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/it/SampleRowsIT.java
}
ApiFutures.allAsList(futures).get(1, TimeUnit.MINUTES);

ApiFuture<List<KeyOffset>> future = client.sampleRowKeysAsync(testEnvRule.env().getTableId());
Copy link
Contributor

@mutianf mutianf Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is doing sample row keys on the table instead of the authorized view?

we'll need to create a table with pre splits and some splits have authorized view rows and some don't
mutianf
mutianf reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@mutianf mutianf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Can we also update the extractTableId logic in https://github.com/googleapis/java-bigtable/blob/main/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/Util.java#L109 so we can extract the table id from authorized view?
  2. Can we add something in the TestEnv to clean up stale authorized view if some tests end up hanging?
feat: Support AuthorizedView in bigtable data client
512818e 
Change-Id: I1e54cab5b384d76166183ac72105a4cbac59979b

chore: Address review comments

Change-Id: I1d9c8bc54d204dbe6752161291cbd4158ee1d6b5

chore: Add @deprecated annotation and reformat javadoc

Change-Id: I3c4a0fcbecc124a9517e48a1fc747c7b8dade40e

chore: Remove ReadRow(s)Options

Change-Id: Ib35bdac2cd51f302fd919671324fb2c0d630af0e

chore: Minor doc and test fix

Change-Id: I3c8e1fa624ec0423433eae15059b5e59e9727c70

Chore: Address comments

Change-Id: I8886e907ebb797a67b36240417c2e609b6f5857a

Rename SampleRowKeys to SampleRowKeysRequest

Change-Id: I8dda7ee1df31b184d04938cbc2f9f984d84138b4

Add javadoc for extractTargetId and hide scopedForAuthorizedView

Change-Id: I38718ae9badf24db6edc1b62fc06e4d3222faeb8

fix extractTableId to correctly handle authorized view name

Change-Id: I1e66fc1440a29d3861e3ee6464911324633cc5af
@trollyxia trollyxia force-pushed the authorized_view_data branch from ae28f38 to 512818e Compare March 27, 2024 21:19
Fix extractTableId() and add a unit test for it
c0d05d8 
Change-Id: Icc172b2b6d369ef8ce2b77a8e69c37af6e9aa3d7
@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 27, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 27, 2024
Mark SampleRowKeysRequest#fromProto as @internalapi
4fd09d6 
Change-Id: I71762fad534fe31f4bf634ca5cb227f014393e37
@mutianf mutianf added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 27, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 27, 2024
@mutianf mutianf added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 27, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 27, 2024
@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 27, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 27, 2024
@igorbernstein2
Copy link
Contributor

igorbernstein2 commented Mar 27, 2024

/gcbrun
@igorbernstein2 igorbernstein2 merged commit 4b255d0 into googleapis:main Mar 27, 2024
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 27, 2024
@release-please release-please bot mentioned this pull request Mar 27, 2024
Merged
@Abacn Abacn mentioned this pull request Apr 5, 2024
Merged
3 tasks
@release-please release-please bot mentioned this pull request Dec 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: xl Pull request size is extra large.

4 participants

@trollyxia @igorbernstein2 @mutianf @yoshi-kokoro