Skip to content

Bump GCP-BOM to 26.36.0#30868

Merged
Abacn merged 4 commits intoapache:masterfrom
Abacn:bumpbom
Apr 9, 2024
Merged

Bump GCP-BOM to 26.36.0#30868
Abacn merged 4 commits intoapache:masterfrom
Abacn:bumpbom

Conversation

@Abacn
Copy link
Contributor

@Abacn Abacn commented Apr 5, 2024

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Abacn
Copy link
Contributor Author

Abacn commented Apr 5, 2024

googleapis/java-bigtable#2177 introduced an overload method causing

> Task :sdks:java:io:google-cloud-platform:compileTestJava
    doReturn(mockBatcher).when(mockBigtableDataClient).newBulkMutationBatcher(any());
                                                      ^
  both method newBulkMutationBatcher(String) in BigtableDataClient and method newBulkMutationBatcher(TargetId) in BigtableDataClient match

fixed the test

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2024

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.26%. Comparing base (ffc96bc) to head (d393efd).
Report is 59 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #30868      +/-   ##
============================================
+ Coverage     61.25%   66.26%   +5.00%     
- Complexity     4470    17763   +13293     
============================================
  Files           853     2252    +1399     
  Lines         74090   143252   +69162     
  Branches       4307    14966   +10659     
============================================
+ Hits          45385    94925   +49540     
- Misses        25224    42351   +17127     
- Partials       3481     5976    +2495     
Flag Coverage Δ
go ?
java 66.26% <ø> (-2.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Abacn
Copy link
Contributor Author

Abacn commented Apr 5, 2024

assign set of reviewers

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @m-trieu for label java.
R: @damccorm for label build.
R: @shunping for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Abacn Abacn merged commit 812e98f into apache:master Apr 9, 2024
@Abacn Abacn deleted the bumpbom branch April 9, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment