ServiceOptions.java: Extract projectId from credentials when provided via .setCredentials` #3386

Activity

1. jabubake commented on Jun 15, 2018

   

   jabubake

   on Jun 15, 2018

   ContributorAuthor

   More actions

   @hostirosti FYI
2. JustinBeckwith

   added

   triage meI really want to be triaged.I really want to be triaged.

   on Jun 15, 2018
3. hostirosti commented on Jun 15, 2018

   

   hostirosti

   on Jun 15, 2018

   More actions

   Example:

   GoogleCredentials creds;
   try {
      InputStream is = MyClass.class.getClassLoader().getResourceAsStream("service_account.json");
      creds = GoogleCredentials.fromStream(is);
   } catch (IOException e) {
      e.printStackTrace();
      return;
   }
   
   ServiceOptions.newBuilder().setCredentials(creds)...
   
4. yihanzhen

   added

   type: questionRequest for information or clarification. Not an issue.Request for information or clarification. Not an issue.

   api: core

   priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.

   and removed

   triage meI really want to be triaged.I really want to be triaged.

   on Jun 15, 2018
5. yihanzhen commented on Jun 15, 2018

   

   yihanzhen

   on Jun 15, 2018

   Contributor

   More actions

   ServiceOptions sets projectId and credentials separately. It would first look for projectId in this sequence, and then look for credentials in this sequence. The reason you have the same projectId when you set the credentials through GOOGLE_APPLICATION_CREDENTIALS is that this json file is the first place ServiceOptions looks for both projectId and credentials if neither of them is set explicitly.

   Though there has been discussions over whether we should extract the projectId from a ServiceAccountCredentials when the credentials is explicitly passed to the ServiceOptions, we generally consider the current behavior intended. Besides, it is possible that users might want the projectId to be different from what is provided in the ServiceAccountCredentials json file.

   We encourage people to use GOOGLE_APPLICATION_CREDENTIALS environment variable over other authentication approaches whenever possible. If you have to manually create and set a credentials, please also set the projectId:

   ServiceOptions options = ServiceOptions.newBuilder()
       .setCredentials(credentials)
       .setProjectId("[project-id]")
       .build();
   
6. yihanzhen

   self-assigned this

   on Jun 15, 2018
7. yihanzhen

   closed this as completedon Jun 18, 2018
8. theacodes

   unassigned

   yihanzhen

   on Sep 28, 2018
9. JustinBeckwith

   assigned

   yihanzhen

   on Feb 1, 2021
10. chingor13

    added 2 commits that reference this issue on Mar 24, 2026

    feat: support DML auto-batching in Connection API (#3386)

    ...

    e350ae1

    chore(main): release 6.79.0 (#3400)

    ...

    076ff38