Skip to content

Adding Snippets has errors #2413

New issue
New issue
Closed
Closed
Adding Snippets has errors#2413
Assignees
pongad
Labels
🚨 criticalP0 critical issue. Requires immediate fixpriority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.type: processA process-related concern. May include testing, release, or the like.

Description

@michaelbausor
michaelbausor
opened on Sep 7, 2017

script: https://github.com/GoogleCloudPlatform/google-cloud-java/blob/master/utilities/add_snippets_to_file.py

  1. Method signature with @nullable does not work.
    Fix:
    At this line in add_snippets_to_file.py#L99, replace the existing:
    ',\s+'.join(['(final\s+)?{}\s+{}'.format(
    with this:
    ',\s+'.join(['(@nullable\s+)?(final\s+)?{}\s+{}'.format(

  2. for all single line comments, the script either fails (when its the last method in the file) or appends javadocs to the successive method.

example:
/** some javadoc */
public String method ( String args );

Activity

  1. michaelbausor
    added
    docs
    priority: p2Moderately-important priority. Fix may not be included in next release.
    type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.
    on Sep 7, 2017
  2. anthmgoogle
    assigned
    anthmgoogle
    and
    michaelbausor
    and unassigned
    anthmgoogle
    on Nov 9, 2017
  3. pongad
    added
    type: processA process-related concern. May include testing, release, or the like.
    on Jan 24, 2018
  4. yihanzhen
    assigned
    yihanzhen
    and unassigned
    michaelbausor
    on Jan 31, 2018

  5. yihanzhen commented on Feb 2, 2018

    @yihanzhen
    yihanzhen
    on Feb 2, 2018
    Contributor

    @pongad It seems your PR will resolve this issue, so I am giving this to you.

  6. yihanzhen
    assigned
    pongad
    and unassigned
    yihanzhen
    on Feb 2, 2018
  7. JustinBeckwith
    added
    🚨 criticalP0 critical issue. Requires immediate fix
    on Jun 8, 2018
  8. pongad
    added a commit that references this issue on Jul 9, 2018

    new approach for snippet injection (#2838)

    aa23ce4

  9. pongad commented on Jul 10, 2018

    @pongad
    pongad
    on Jul 10, 2018
    Contributor

    Should be fixed by #2838.

  10. pongad
    closed this as completedon Jul 10, 2018
  11. snehashah16
    added a commit that references this issue on Sep 18, 2018

    Sync to master head (#3698)

    d9d7adc
  12. theacodes
    unassigned
    pongad
    on Sep 28, 2018
  13. JustinBeckwith
    assigned
    pongad
    on Feb 1, 2021
  14. chingor13
    added 2 commits that reference this issue on Feb 20, 2026

    feat: Add the RANGE type to the google.cloud.bigquery.storage.v1.Tabl…

    6aa92b5

    chore(main): release 3.3.0 (#2415)

    023df3b
  15. meltsufin
    added 4 commits that reference this issue on Apr 29, 2026

    new approach for snippet injection (#2838)

    5f3fa09

    deps: update dependency com.google.cloud:google-cloud-core to v2.55.0 (…

    3e181e7

    new approach for snippet injection (#2838)

    f0cd500

    deps: update dependency com.google.cloud:google-cloud-core to v2.55.0 (…

    0ff9725
  16. benjaminp
    added a commit that references this issue on Jul 13, 2026

    chore(main): release 2.47.1-SNAPSHOT (googleapis#2413)

    2161e17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

🚨 criticalP0 critical issue. Requires immediate fixpriority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.type: processA process-related concern. May include testing, release, or the like.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions