feat(pubsub): batch receipt modacks#10234
Merged
hongalex merged 8 commits intogoogleapis:mainfrom May 20, 2024
Merged
Conversation
alvarowolfx
approved these changes
May 20, 2024
…ex/google-cloud-go into feat-pubsub-batch-receipt-modacks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the receipt modacks (modack RPCs that are sent upon message receipt) batched in a similar mechanism to existing ack/modack RPCs. This change only affects non-exactly once delivery. EOD subscriptions will still issue modacks RPCs synchronously.
Closes #10166