fix(pubsub): respect gRPC dial option when PUBSUB_EMULATOR_HOST is set#10040
Merged
hongalex merged 6 commits intogoogleapis:mainfrom May 6, 2024
Merged
fix(pubsub): respect gRPC dial option when PUBSUB_EMULATOR_HOST is set#10040hongalex merged 6 commits intogoogleapis:mainfrom
hongalex merged 6 commits intogoogleapis:mainfrom
Conversation
hongalex
approved these changes
May 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10039
This implementation was based on the following implementation of Spanner Client.
google-cloud-go/spanner/client.go
Lines 252 to 261 in 4d85153