Skip to content

Stop the child output reading when the child process ends. #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stop the child output reading when the child process ends. #1712

copybara-service wants to merge 1 commit into from

Conversation

@copybara-service
Copy link
Contributor

@copybara-service copybara-service bot commented May 22, 2025

Stop the child output reading when the child process ends.

Otherwise, the child process could terminate without fully closing the pipes, causing unwanted delays - see the added test.
@xinhaoyuan @copybara-github
Stop the child output reading when the child process ends.
23be287 
Otherwise, the child process could terminate without fully closing the pipes, causing unwanted delays - see the added test.

PiperOrigin-RevId: 762172820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@xinhaoyuan