Repository navigation
Specify Swift names for GIDClaim methods - #627
Merged
Merged
Conversation
Contributor
Author
|
Here is the pre- post- diff of the API, to ensure that it is identical: $ xcrun swift-api-digester -dump-sdk -module GoogleSignIn -I before -I $FETCHER_HEADERS -o before.json … PRE (origin/main, 0 annotations): POST (branch, 4 annotations): |
w-goog
force-pushed
the
feature/gidclaim-swift-names
branch
from
August 27, 2026 23:06
29dc70c to
013a799
Compare
AkshatG6
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Obj-C method
- (instancetype)AMRClaim;gets rewritten toGIDClaim.amr()by Swift's Obj-C importer. This is ~fine, but a) not discoverable by reading the file and b) could plausibly change if the Obj-C importer changes its behaviour. That is not very nice, so, this PR pins the names.(Does this seem like a silly thing to spend time on? Yes. Did it already bite once and require a developer docs update? Also yes)