Repository navigation
Update AppAuth dependency minimum to 2.1.0 - #603
Merged
Merged
Conversation
AkshatG6
approved these changes
Jun 12, 2026
brnnmrls
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raises the AppAuth-iOS dependency minimum to 2.1.0 (release notes) ahead of the GoogleSignIn-iOS 9.2.0 release, and adopts the new AppAuth API:
GoogleSignIn.podspec:AppAuth~> 2.0→~> 2.1Package.swift/Package@swift-5.5.swift: AppAuth-iOSfrom: "2.0.0"→from: "2.1.0"CHANGELOG.md: entry under UnreleasedGIDSignIn.m: adoptresumeExternalUserAgentFlowWithURL:error:(passing a nil error outparam, behaviorally identical to the now-deprecatedresumeExternalUserAgentFlowWithURL:). Required alongside the bump: AppAuth 2.1.0 deprecates the old selector, and the resulting warning failspod lib lint. Since 2.1.0 is live on the CocoaPods trunk,main's~> 2.0already resolves to it — this failure will exist on all PRs until this change lands. Notably, the old method was swapped to call the new one, so this change is net-neutral on risk.Samples/Swift/DaysUntilBirthday: addClaim.swiftto the DaysUntilBirthdayForPod project so the sample builds with CocoaPods (folded in from g-orchestrated: add Claim.swift to DaysUntilBirthdayForPod project #604, which is closed as superseded).AppAuth 2.1.0 brings the in-app browser fallback removal (openid/AppAuth-iOS#954) and
resumeExternalUserAgentFlowWithURL:error:(openid/AppAuth-iOS#955). SPM dependency resolution verified locally (AppAuth resolves at 2.1.0).Note for reviewers:
swift-button-functional-testis a pre-existing flake (same failures onmainpushes from March–April) and is unrelated to these changes.SKIP_INTEGRATION_TESTS=YES