Skip to content

Add unit tests for AMR claim - #575

Merged
AkshatG6 merged 3 commits into
gandhiakshat/sbc-amr-mainfrom
gandhiakshat/sbc-amr-additional-tests
Jan 26, 2026
Merged

AkshatG6 merged 3 commits into
gandhiakshat/sbc-amr-mainfrom
gandhiakshat/sbc-amr-additional-tests

Conversation

@AkshatG6

@AkshatG6 AkshatG6 commented Jan 26, 2026 •

Copy link
Copy Markdown
Contributor

This PR adds unit tests for the AMR claim within GIDSignInTest.

It also includes a refactor of existing tests to improve maintainability and scalability:

  • Updates existing tests in GIDSignInTest and OIDTokenResponse + Testing for a cleaner codebase.
  • Removes testInstanceWithIDToken...authTime:(NSString *)authTime... as no intended usage was found.
  • Updates fatIDTokenWithAuthTime to fatIDTokenWithClaims to better reflect its behavior.
  • Renames existing tests and parameters (e.g., authTime to claims) to allow tests to be more easily extended in the future.
@AkshatG6
AkshatG6 requested a review from mdmathias January 26, 2026 17:58
@AkshatG6
AkshatG6 requested a review from mdmathias January 26, 2026 18:37
@AkshatG6
AkshatG6 merged commit bd48ccb into gandhiakshat/sbc-amr-main Jan 26, 2026
13 checks passed
@AkshatG6
AkshatG6 deleted the gandhiakshat/sbc-amr-additional-tests branch January 26, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants