Skip to content

Fix callback for nested signIn or addScopes - #29

Merged
petea merged 2 commits into
google:mainfrom
AntonKozlovskyi:Fix_missing_completion_handler_on_add_scopes
Jul 19, 2021
Merged

petea merged 2 commits into
google:mainfrom
AntonKozlovskyi:Fix_missing_completion_handler_on_add_scopes

Conversation

@AntonKozlovskyi

@AntonKozlovskyi AntonKozlovskyi commented Jul 19, 2021 •

Copy link
Copy Markdown
Contributor

Fixes #24

@google-cla

google-cla Bot commented Jul 19, 2021

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@AntonKozlovskyi

Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

@petea petea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Anton! Could you also apply this fix to the two other locations in GIDSignIn.m where we set "_currentOptions = nil" after executing the callback block?

Comment thread GoogleSignIn/Sources/GIDSignIn.m Resolved
Comment thread GoogleSignIn/Sources/GIDSignIn.m Resolved
@AntonKozlovskyi

Copy link
Copy Markdown
Contributor Author

done

@AntonKozlovskyi
AntonKozlovskyi requested a review from petea July 19, 2021 19:37
@petea petea changed the title fix calling callback on addScopes Jul 19, 2021
@petea
petea merged commit e6d17e9 into google:main Jul 19, 2021
@petea petea added this to the 6.0.1 milestone Jul 21, 2021

@tgun1370 tgun1370 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AntonKozlovskyi:Fix_missing_completion_handler_on_add_scopes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants