Skip to content

GSI macOS support preparation - #102

Merged
petea merged 1 commit into
mainfrom
pin-macOSSupport
Mar 9, 2022
Merged

GSI macOS support preparation#102
petea merged 1 commit into
mainfrom
pin-macOSSupport

Conversation

@Alex-4-Git

@Alex-4-Git Alex-4-Git commented Feb 26, 2022

Copy link
Copy Markdown
Contributor
  1. Edit Cocoapods and Swift Package manager config file.
  2. Annotate iOS specific components.
@Alex-4-Git
Alex-4-Git force-pushed the pin-macOSSupport branch 2 times, most recently from 71a44d3 to deba5dc Compare February 26, 2022 02:05
@Alex-4-Git Alex-4-Git mentioned this pull request Mar 1, 2022
Merged
mdmathias
mdmathias approved these changes Mar 8, 2022
View reviewed changes

@mdmathias mdmathias left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I do suggest using #import if there is no reason to use #include.
Comment thread GoogleSignIn/Sources/GIDEMMErrorHandler.h Resolved
petea
petea suggested changes Mar 8, 2022
View reviewed changes
Comment thread GoogleSignIn.podspec Resolved
Comment thread Package.swift Resolved
Comment thread GoogleSignIn/Sources/GIDEMMErrorHandler.h Resolved
Comment thread GoogleSignIn/Sources/GIDEMMErrorHandler.m Resolved
Comment thread GoogleSignIn/Sources/GIDMDMPasscodeCache.h Resolved
Comment thread GoogleSignIn/Sources/GIDMDMPasscodeCache.m Resolved
Comment thread GoogleSignIn/Sources/GIDMDMPasscodeState.h Resolved
Comment thread GoogleSignIn/Sources/GIDMDMPasscodeState.m Resolved
Comment thread GoogleSignIn/Sources/GIDMDMPasscodeState_Private.h Resolved
ch40w31
ch40w31 reviewed Mar 8, 2022
View reviewed changes
Comment thread GoogleSignIn/Sources/GIDEMMErrorHandler.h Resolved
@Alex-4-Git

Alex-4-Git commented Mar 8, 2022

Copy link
Copy Markdown
Contributor Author

Close this PR since we can only exclude the header when they are not used.
@Alex-4-Git Alex-4-Git closed this Mar 8, 2022
@Alex-4-Git Alex-4-Git reopened this Mar 9, 2022
@mdmathias
mdmathias self-requested a review March 9, 2022 01:08
@Alex-4-Git
Alex-4-Git requested a review from petea March 9, 2022 01:57
@petea
petea merged commit a20152c into main Mar 9, 2022
@petea petea added this to the 6.2.0 milestone Mar 9, 2022
@Alex-4-Git
Alex-4-Git deleted the pin-macOSSupport branch May 25, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@Alex-4-Git @petea @mdmathias @ch40w31