Repository navigation
GoogleSignIn does not define a clang module, cannot @import GoogleSignIn when built as a library #32
Description
GoogleSignIn does not generate a clang module when built as a library instead of a framework. This forces users to use use_frameworks! in their Podfile, which isn't the default.
Steps to Reproduce
- Remove
use_frameworks!from Sample Podfile to generate as a library
GoogleSignIn-iOS/Sample/Podfile
Line 2 in 954652d
- Open SignInSampleForPod.xcworkspace and build.
Compilation failure:
GoogleSignIn-iOS/Sample/Source/SignInViewController.h:19:9: Module 'GoogleSignIn' not found
To fix
Add 'DEFINES_MODULE' => 'YES' to pod_target_xcconfig
GoogleSignIn-iOS/GoogleSignIn.podspec
Lines 38 to 41 in 5193a5b
becomes:
s.pod_target_xcconfig = {
'GCC_PREPROCESSOR_DEFINITIONS' => 'GID_SDK_VERSION=' + s.version.to_s,
'HEADER_SEARCH_PATHS' => '"${PODS_TARGET_SRCROOT}"',
'DEFINES_MODULE' => 'YES'
} See "Modular Headers" section of https://blog.cocoapods.org/CocoaPods-1.5.0/
Reacted by Pierluigi Cifani
Activity
piercifani commentedon Jul 28, 2021
Can we please fix this ASAP? This is breaking integration for many apps for versions 6.0 and up, and that version is required in order to use GSignIn in M1 Macs.
This is unacceptable.
paulb777 commentedon Jul 28, 2021
A possible workaround is adding
use_frameworks! :linkage => :staticto the Podfile. See the discussion in #33 for more context.piercifani commentedon Jul 28, 2021
Changing how all other Pods are built and linked sounds like a worse option than just add that flag to the Podspec to define the module, because it'll add a lot of uncertainty to all other libraries
piercifani commentedon Aug 11, 2021
Guys, is anyone going to do anything about this or do we have to figure this out on our own?