Skip to content

Fix tests for removing outdated models - #81

Merged
wanlin31 merged 2 commits into
mainfrom
fix-test
Oct 8, 2026
Merged

wanlin31 merged 2 commits into
mainfrom
fix-test

Conversation

@wanlin31

@wanlin31 wanlin31 commented Oct 7, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@wanlin31
wanlin31 requested a review from a team October 7, 2026 21:50
@wanlin31 wanlin31 changed the title Fix tests for image gen default Oct 7, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the expected model versions in contract tests, changing references to newer Gemini models like gemini-3.1-pro-preview and gemini-3.8-flash. However, a review comment points out that updating the test assertion in models_test.go to expect gemini-3.8-flash will cause the test to fail because the underlying command example in internal/cli/models/modelsget.go still uses gemini-2.5-flash and needs to be updated accordingly.

Comment thread tests/contract/models_test.go Resolved
2ynn
2ynn previously approved these changes Oct 7, 2026
@wanlin31
wanlin31 merged commit cff3cb3 into main Oct 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants