Skip to content

test(contract): drop planned tokens and docs placeholder assertions - #70

Merged
ThomasRooney merged 1 commit into
mainfrom
tests/994586726
Oct 8, 2026
Merged

ThomasRooney merged 1 commit into
mainfrom
tests/994586726

Conversation

@ThomasRooney

@ThomasRooney ThomasRooney commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Removing the planned tokens and docs placeholder commands from the CLI overlay (commands.yaml and help.yaml).

Update TestGenerateIntentCommand, TestExitCodeContract, and TestHelpBudgetAndFooter to stop asserting on the removed tokens and docs placeholders.

@ThomasRooney
ThomasRooney requested a review from a team October 6, 2026 20:42
@google-cla

google-cla Bot commented Oct 6, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes test cases and assertions for the planned placeholder commands docs and tokens from the contract tests, specifically in cli_contract_test.go, exitcodes_test.go, and help_test.go. I have no feedback to provide.

@ThomasRooney
ThomasRooney force-pushed the tests/994586726 branch 2 times, most recently from 8b00b51 to d8cd468 Compare October 7, 2026 12:08
@2ynn
2ynn requested a review from wanlin31 October 8, 2026 21:12
@ThomasRooney
ThomasRooney merged commit cf8d6f5 into main Oct 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants