Repository navigation
test(contract): expect generated double-identifier wording on models get - #43
Conversation
… get` 1fa466c moved `models get` onto the generated positional wiring, which reports a doubly supplied identifier as "pass model once: as the [model] argument or via --model, not both". TestModelsGetRejectsDoubleIdentifier still pinned the removed hand-written "pass the identifier once" message and failed on main.
![gemini-code-assist[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the TestModelsGetRejectsDoubleIdentifier test in tests/contract/models_test.go to assert the error message 'pass model once' instead of 'pass the identifier once', aligning with the updated error message. I have no feedback to provide as there are no review comments.
|
Stop sanding me e mail i dont undrstend them
בתאריך יום ג׳, 29 בספט׳ 2026, 01:05, מאת Qynn Schwaab <
***@***.***>:
… Merged #43 <#43> into
main.
—
Reply to this email directly, view it on GitHub
<#43?email_source=notifications&email_token=CMWAUNVM7NEDTB7SHN7VWPL5RLOCTA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTGMRQGMZDGMJWGQZDHJTSMVQXG33OVJZXKYTTMNZGSYTFMSSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#event-32032316423>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/CMWAUNRJWREGNQLXHEXL6JL5RLOCTAVCNFSNUABGKJSXA33TNF2G64TZHMYTEMRUG4YTKMBRGM5US43TOVSTWNJWGIYTOMJVHA2DLILWAI>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/CMWAUNVMAJE25SZXQNQEPQD5RLOCTA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTGMRQGMZDGMJWGQZDHJTSMVQXG33OVJZXKYTTMNZGSYTFMSSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/CMWAUNWMTUUVOROU3227XDL5RLOCTA5CNFSNUABQM5UWIORPF5TWS5BNNB2WEL2JONZXKZKFOZSW45CON52GSZTJMNQXI2LPNYXTGMRQGMZDGMJWGQZDHJTSMVQXG33OVJZXKYTTMNZGSYTFMSSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***
com>
|
|
Hi @BenJomy Sorry for the inconvenience here. You are receiving these notifications because your GitHub account is watching/subscribed to this repository. To stop receiving emails, go to https://github.com/google-gemini/gemini-api-cli I think the content sent to you is in Is Hebrew, maybe your email is configured to Hebrew? |
go test ./...fails onmainsince 1fa466c:1fa466c replaced the hand-written
addPositionalIdentifierwith the generated positional wiring, so a doubly supplied identifier now reports the generated message (pass model once: …) instead ofpass the identifier once. The CLI behaviour is correct; the contract test still pinned the removed wording.This updates the expected substring (and the test's doc comment).
go test ./...is green onmainwith this change.