Repository navigation
fix(timeout, streaming): bump version to 0.2.1, increase server timeout to 30000, and fix streaming format for unknown steps - #12
Conversation
…ut to 30000, and fix streaming format for unknown steps
![gemini-code-assist[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request bumps the package version to 0.2.1, increases the server timeout header from 600 to 30000 seconds across API requests and curl outputs, and adds a test case for the HumanStreamRenderer handling unknown step types. The reviewer identified a potential typo in the new timeout value, pointing out a mismatch between the client-side timeout limit (3,000 seconds) and the server-side timeout (30,000 seconds), and suggested aligning them to 3,000 seconds.
| "Content-Type": "application/json", | ||
| "x-goog-api-key": ctx.apiKey, | ||
| "x-server-timeout": "600", | ||
| "x-server-timeout": "30000", |
There was a problem hiding this comment.
There is a mismatch between the client-side timeout and the server-side timeout. The client-side fetchWithTimeout helper defaults to 3,000,000 ms (3,000 seconds / 50 minutes), whereas the server-side timeout header x-server-timeout is set to "30000" (30,000 seconds / ~8.3 hours). If the server-side timeout is indeed intended to be 30,000 seconds, the client will abort the request after 3,000 seconds, making the server timeout ineffective. If the intention was to align the server timeout with the client-side timeout of 3,000 seconds, then "30000" contains an extra zero typo and should be "3000". Please verify and align these values.
| "x-server-timeout": "30000", | |
| "x-server-timeout": "3000", |
| "Content-Type": "application/json", | ||
| "x-goog-api-key": ctx.apiKey, | ||
| "x-server-timeout": "600", | ||
| "x-server-timeout": "30000", |
There was a problem hiding this comment.
There is a mismatch between the client-side timeout and the server-side timeout. The client-side fetchWithTimeout helper defaults to 3,000,000 ms (3,000 seconds / 50 minutes), whereas the server-side timeout header x-server-timeout is set to "30000" (30,000 seconds / ~8.3 hours). If the server-side timeout is indeed intended to be 30,000 seconds, the client will abort the request after 3,000 seconds, making the server timeout ineffective. If the intention was to align the server timeout with the client-side timeout of 3,000 seconds, then "30000" contains an extra zero typo and should be "3000". Please verify and align these values.
| "x-server-timeout": "30000", | |
| "x-server-timeout": "3000", |
No description provided.