-
Notifications
You must be signed in to change notification settings - Fork 366
_content/doc/tutorial/greetings-multiple-people.html: Add missing Indication of changes #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
This PR (HEAD: bec2c18) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/website/+/354849 to see it. Tip: You can toggle comments from me using the |
|
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/354849. |
|
This PR (HEAD: 1c097ae) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/website/+/354849 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: 80f546a) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/website/+/354849 to see it. Tip: You can toggle comments from me using the |
654a8c5 to
df8e714
Compare
|
This PR (HEAD: 2e0f5ba) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/website/+/354849 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: df8e714) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/website/+/354849 to see it. Tip: You can toggle comments from me using the |
|
Message from Lukas Joisten: Patch Set 5: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/354849. |
|
This PR (HEAD: 0640b30) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/website/+/354849 to see it. Tip: You can toggle comments from me using the |
|
Message from Lukas Joisten: Patch Set 6: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/354849. |
…ication of changes In line 162 the argument of Hellos changes from "Gladys" into names. The indication of a change was missing in the code block.
|
This PR (HEAD: b4b2252) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/website/+/354849 to see it. Tip: You can toggle comments from me using the |
|
I just saw that there are 3 other pull requests concerning this issue: @sethbattin is waiting since April to get approved... |
|
Message from Lukas Joisten: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/354849. |
|
Message from Lukas Joisten: Patch Set 8: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/354849. |
In line 162 the argument of Hellos changes from "Gladys" into names. The indication of a change was missing in the code block.