Skip to content

Conversation

@Lukas-J
Copy link

@Lukas-J Lukas-J commented Oct 8, 2021

In line 162 the argument of Hellos changes from "Gladys" into names. The indication of a change was missing in the code block.

@google-cla
Copy link

google-cla bot commented Oct 8, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Oct 8, 2021
@Lukas-J
Copy link
Author

Lukas-J commented Oct 8, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Oct 8, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: bec2c18) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/website/+/354849 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/354849.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 1c097ae) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/website/+/354849 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 80f546a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/website/+/354849 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@Lukas-J Lukas-J force-pushed the patch-1 branch 2 times, most recently from 654a8c5 to df8e714 Compare March 7, 2022 23:57
@gopherbot
Copy link
Contributor

This PR (HEAD: 2e0f5ba) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/website/+/354849 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: df8e714) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/website/+/354849 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Lukas Joisten:

Patch Set 5: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/354849.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 0640b30) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/website/+/354849 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Lukas Joisten:

Patch Set 6: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/354849.
After addressing review feedback, remember to publish your drafts!

…ication of changes

In line 162 the argument of Hellos changes from "Gladys" into names. The indication of a change was missing in the code block.
@gopherbot
Copy link
Contributor

This PR (HEAD: b4b2252) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/website/+/354849 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@Lukas-J Lukas-J changed the title Add missing Indication of changes to line 162 Mar 8, 2022
@Lukas-J
Copy link
Author

Lukas-J commented Mar 8, 2022

I just saw that there are 3 other pull requests concerning this issue:
#49
#121
#135

@sethbattin is waiting since April to get approved...

@gopherbot
Copy link
Contributor

Message from Lukas Joisten:

Patch Set 8:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/354849.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Lukas Joisten:

Patch Set 8:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/354849.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.

3 participants