tour: let reader know Walk should send in order #202
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In "Exercise: Equivalent Binary Trees" neither the slide text nor the code state Walk() should send the values in order. Doing so in order makes using the output much more useful in Same(), but might not be easy to see for readers that have not had a data structures class. In order traversal is implied by reference with the binary tree being "always sorted" and the output defined as "should be the numbers 1, 2, 3, ..., 10." Update the slide text to say what Walk() does. Change Walk() comments in code/solution to match. Fixes golang/tour#158
Contributor
|
This PR (HEAD: e1db6b5) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/website/+/472315 to see it. Tip: You can toggle comments from me using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In "Exercise: Equivalent Binary Trees" neither the slide text nor the code state Walk() should send the values in order. Doing so in order makes using the output much more useful in Same(), but might not be easy to see for readers that have not had a data structures class. In order traversal is implied by reference with the binary tree being "always sorted" and the output defined as "should be the numbers 1, 2, 3, ..., 10."
Update the slide text to say what Walk() does. Change Walk() comments in code/solution to match.
Fixes golang/tour#158