Skip to content

cmd/gendb: fix flag defaults #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
knqyf263 wants to merge 1 commit into from
Closed

cmd/gendb: fix flag defaults #3

knqyf263 wants to merge 1 commit into from

Conversation

@knqyf263
Copy link
Contributor

@knqyf263 knqyf263 commented Apr 28, 2021

Looks like the usage specification is wrong.

Before:

$ gendb -h
Usage of gendb:
  -out string
         (default "Directory to write JSON database to")
  -reports string
         (default "Directory containing toml reports")

After:

$ gendb -h
Usage of /var/folders/j7/pvz71jxn637dqd96gm80nhwm0000gn/T/go-build330871962/b001/exe/main:
  -out string
        Directory to write JSON database to (default "out")
  -reports string
        Directory containing toml reports (default "reports")
@google-cla google-cla bot added the cla: yes label Apr 28, 2021
@gopherbot
Copy link
Contributor

gopherbot commented Apr 28, 2021

This PR (HEAD: 8cdb001) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vulndb/+/314550 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
@gopherbot
Copy link
Contributor

gopherbot commented May 27, 2021

Message from Roland Shoemaker:

Patch Set 1: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/314550.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented May 27, 2021

Message from Michael Knyszek:

Patch Set 1: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/314550.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented May 28, 2021

This PR (HEAD: 07a42f8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vulndb/+/314550 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
@knqyf263 knqyf263 changed the title Correct usages and values May 28, 2021
@gopherbot
Copy link
Contributor

gopherbot commented May 28, 2021

Message from Teppei Fukuda:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/314550.
After addressing review feedback, remember to publish your drafts!
gopherbot pushed a commit that referenced this pull request Jun 1, 2021
@knqyf263 @rolandshoemaker
cmd/gendb: fix flag defaults
fb8be7b 
Looks like the usage specification is wrong.

Before:

```
$ gendb -h
Usage of gendb:
  -out string
         (default "Directory to write JSON database to")
  -reports string
         (default "Directory containing toml reports")
```

After:

```
$ gendb -h
Usage of /var/folders/j7/pvz71jxn637dqd96gm80nhwm0000gn/T/go-build330871962/b001/exe/main:
  -out string
        Directory to write JSON database to (default "out")
  -reports string
        Directory containing toml reports (default "reports")
```

Change-Id: I47fd858bdcb19eb22e5aefc7d891497c58e567ba
GitHub-Last-Rev: 07a42f8
GitHub-Pull-Request: #3
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/314550
Reviewed-by: Roland Shoemaker <roland@golang.org>
Trust: Michael Knyszek <mknyszek@google.com>
@gopherbot
Copy link
Contributor

gopherbot commented Jun 1, 2021

This PR is being closed because golang.org/cl/314550 has been merged.
@gopherbot gopherbot closed this Jun 1, 2021
@GoVulnBot GoVulnBot mentioned this pull request Dec 30, 2022
Closed
gopherbot pushed a commit that referenced this pull request Jan 3, 2023
@neild
data/reports: add GHSA to GO-2020-0003.yaml
f2d2dfa 
Aliases: CVE-2020-36568, GHSA-hggr-p7v6-73p5

Updates #3
Fixes #1211

Change-Id: I67ee06c1a726b1cde131b1fd087bf4611a8b5c6f
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/460417
Run-TryBot: Damien Neil <dneil@google.com>
Reviewed-by: Zvonimir Pavlinovic <zpavlinovic@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
sayjun0505 added a commit to sayjun0505/Golangvuln that referenced this pull request Apr 8, 2023
@sayjun0505
cmd/gendb: fix flag defaults
f75a53e 
Looks like the usage specification is wrong.

Before:

```
$ gendb -h
Usage of gendb:
  -out string
         (default "Directory to write JSON database to")
  -reports string
         (default "Directory containing toml reports")
```

After:

```
$ gendb -h
Usage of /var/folders/j7/pvz71jxn637dqd96gm80nhwm0000gn/T/go-build330871962/b001/exe/main:
  -out string
        Directory to write JSON database to (default "out")
  -reports string
        Directory containing toml reports (default "reports")
```

Change-Id: I47fd858bdcb19eb22e5aefc7d891497c58e567ba
GitHub-Last-Rev: 07a42f8685fd760933d6c86659e8dd28d43577e5
GitHub-Pull-Request: golang/vulndb#3
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/314550
Reviewed-by: Roland Shoemaker <roland@golang.org>
Trust: Michael Knyszek <mknyszek@google.com>
stanislavkononiuk added a commit to stanislavkononiuk/Golangvuln that referenced this pull request Jun 26, 2023
@stanislavkononiuk
cmd/gendb: fix flag defaults
a96e13e 
Looks like the usage specification is wrong.

Before:

```
$ gendb -h
Usage of gendb:
  -out string
         (default "Directory to write JSON database to")
  -reports string
         (default "Directory containing toml reports")
```

After:

```
$ gendb -h
Usage of /var/folders/j7/pvz71jxn637dqd96gm80nhwm0000gn/T/go-build330871962/b001/exe/main:
  -out string
        Directory to write JSON database to (default "out")
  -reports string
        Directory containing toml reports (default "reports")
```

Change-Id: I47fd858bdcb19eb22e5aefc7d891497c58e567ba
GitHub-Last-Rev: 07a42f8685fd760933d6c86659e8dd28d43577e5
GitHub-Pull-Request: golang/vulndb#3
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/314550
Reviewed-by: Roland Shoemaker <roland@golang.org>
Trust: Michael Knyszek <mknyszek@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes

2 participants

@knqyf263 @gopherbot