Skip to content

Conversation

@tamayika
Copy link
Contributor

@tamayika tamayika commented Aug 15, 2025

Fixes #3837

@gopherbot
Copy link
Collaborator

This PR (HEAD: f8c19cc) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/696355.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Collaborator

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/696355.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Ethan Reesor:

Patch Set 1: Commit-Queue+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/696355.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-08-15T16:49:10Z","revision":"df00d01e6c010b7109738d9f22602ab287eb78b1"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/696355.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Ethan Reesor:

Patch Set 1: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/696355.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Go LUCI:

Patch Set 1:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/696355.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/696355.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Hongxiang Jiang:

Patch Set 1: Code-Review+2

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/696355.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

This PR (HEAD: 2d7676b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/vscode-go/+/696355.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@tamayika tamayika changed the title extension: save only dirty files Aug 16, 2025
@gopherbot
Copy link
Collaborator

Message from yika tama:

Patch Set 2:

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/696355.
After addressing review feedback, remember to publish your drafts!

@tamayika tamayika changed the title extension/src/goTest: save only dirty files: save only dirty files Aug 16, 2025
@gopherbot
Copy link
Collaborator

Message from Carlos Amedee:

Patch Set 4: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/696355.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Aug 18, 2025
Fixes #3837

Change-Id: I46bbd7d3c4dea866bff2419a631f2407d6989835
GitHub-Last-Rev: 2d7676b
GitHub-Pull-Request: #3838
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/696355
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hongxiang Jiang <hxjiang@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
@gopherbot
Copy link
Collaborator

This PR is being closed because golang.org/cl/696355 has been merged.

@gopherbot gopherbot closed this Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants