internal/refactor/inline: preserve local package name used by callee #601

gavinkflam · 2025-10-20T04:50:18Z

The existing implementation generates local package names by appending
a numeric suffix to package name, which reduces readability.

This improvement preserves the local package name used by the callee when
available and fall back to the existing name generation mechanism if a
conflict occurs.

Updates golang/go#63352
Fixes golang/go#74965

gopherbot · 2025-10-20T05:01:10Z

This PR (HEAD: 37368b6) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/712981.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-20T05:17:58Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-20T05:17:58Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-20T05:26:30Z

Message from Gavin Lam:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-21T15:45:52Z

Message from t hepudds:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-21T15:45:53Z

Message from t hepudds:

Patch Set 1: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-21T15:55:25Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-21T15:33:31Z","revision":"52a26e43227e83b56db65b17d9e59e2f43a541a8"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-21T16:05:17Z

Message from t hepudds:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-21T16:05:18Z

Message from Go LUCI:

Patch Set 1:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64-race has failed with summary (view all results):

go on master (commit 306eacb) / tools on master (change 712981)

To reproduce, try gomote repro 8700387610345756337.

Additional links for debugging:

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-21T16:05:19Z

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-22T03:20:11Z

Message from Gavin Lam:

Patch Set 2:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-22T03:37:14Z

Message from Gavin Lam:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-10-22T22:46:47Z

This PR (HEAD: 5a7a316) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/712981.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-10-23T00:19:28Z

Message from Gavin Lam:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-08T03:29:16Z

This PR (HEAD: d34adad) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/712981.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-11-24T06:05:36Z

Message from Gavin Lam:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-25T17:29:04Z

Message from Alan Donovan:

Patch Set 4: Code-Review+2

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-25T17:29:05Z

Message from Robert Findley:

Patch Set 4: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-26T03:38:13Z

This PR (HEAD: 476be48) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/712981.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-11-26T03:55:04Z

Message from Gavin Lam:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-26T03:55:05Z

Message from Alan Donovan:

Patch Set 5: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-26T04:03:28Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-11-26T03:45:26Z","revision":"b31e60d7e5359d20c61e251d6d23d54e6112b92d"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-26T04:03:29Z

Message from Alan Donovan:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-26T04:03:29Z

Message from Go LUCI:

Patch Set 5:

This CL has failed the run. Reason:

Failed Tryjobs:

golang/try/x_tools-gotip-linux-amd64_debiansid. Summary (view all results):

go on master (commit 03f499e) / tools on master (change 712981)

To reproduce, try gomote repro 8697170669241598817.

Additional links for debugging:

golang/try/x_tools-gotip-linux-arm64-boringcrypto. Summary (view all results):

go on master (commit 03f499e) / tools on master (change 712981)

To reproduce, try gomote repro 8697170669241598785.

Additional links for debugging:

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-26T04:03:30Z

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

The existing implementation generates local package names by appending a numeric suffix to package name, which reduces readability. This improvement preserves the local package name used by the callee when available and fall back to the existing name generation mechanism if a conflict occurs. Updates golang/go#63352 Fixes golang/go#74965 Signed-off-by: Gavin Lam <gavin.oss@tutamail.com>

gopherbot · 2025-11-26T04:12:03Z

This PR (HEAD: f67b6a9) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/712981.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-11-26T04:29:34Z

Message from Gavin Lam:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-26T14:24:45Z

Message from Robert Findley:

Patch Set 6: Code-Review+1 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-26T14:24:46Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-11-26T14:13:34Z","revision":"dac95e7b371039507e340986a6d9dfa7417d0f94"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-26T14:24:46Z

Message from Robert Findley:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-26T14:53:21Z

Message from Robert Findley:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-26T14:53:22Z

Message from Go LUCI:

Patch Set 6:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-26T14:53:23Z

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

The existing implementation generates local package names by appending a numeric suffix to package name, which reduces readability. This improvement preserves the local package name used by the callee when available and fall back to the existing name generation mechanism if a conflict occurs. Updates golang/go#63352 Fixes golang/go#74965 Change-Id: I5fdf5948cf6036786f6e92458c9d53210f2d5450 GitHub-Last-Rev: f67b6a9 GitHub-Pull-Request: #601 Reviewed-on: https://go-review.googlesource.com/c/tools/+/712981 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Robert Findley <rfindley@google.com> Reviewed-by: Alan Donovan <adonovan@google.com>

gopherbot · 2025-11-26T15:03:24Z

Message from Gavin Lam:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/712981.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-11-26T15:13:34Z

This PR is being closed because golang.org/cl/712981 has been merged.

gavinkflam changed the title ~~internal/refactor/inline: preserve alias when choosing a local name for imported package~~ Oct 22, 2025

gavinkflam force-pushed the 74965-inline-preserve-import-alias branch from 37368b6 to 5a7a316 Compare October 22, 2025 22:40

gavinkflam force-pushed the 74965-inline-preserve-import-alias branch from 5a7a316 to d34adad Compare November 8, 2025 03:26

gavinkflam force-pushed the 74965-inline-preserve-import-alias branch from d34adad to 476be48 Compare November 26, 2025 03:36

gavinkflam changed the title ~~internal/refactor/inline: improve package local name by preserving alias~~ Nov 26, 2025

gavinkflam force-pushed the 74965-inline-preserve-import-alias branch from 476be48 to f67b6a9 Compare November 26, 2025 04:07

gopherbot closed this Nov 26, 2025

internal/refactor/inline: preserve local package name used by callee #601

internal/refactor/inline: preserve local package name used by callee #601

Uh oh!

Conversation

gavinkflam commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

gopherbot commented Oct 20, 2025

gopherbot commented Oct 20, 2025

gopherbot commented Oct 20, 2025

gopherbot commented Oct 20, 2025

gopherbot commented Oct 21, 2025

gopherbot commented Oct 21, 2025

gopherbot commented Oct 21, 2025

gopherbot commented Oct 21, 2025

gopherbot commented Oct 21, 2025

gopherbot commented Oct 21, 2025

gopherbot commented Oct 22, 2025

gopherbot commented Oct 22, 2025

gopherbot commented Oct 22, 2025

gopherbot commented Oct 23, 2025

gopherbot commented Nov 8, 2025

gopherbot commented Nov 24, 2025

gopherbot commented Nov 25, 2025

gopherbot commented Nov 25, 2025

gopherbot commented Nov 26, 2025

gopherbot commented Nov 26, 2025

gopherbot commented Nov 26, 2025

gopherbot commented Nov 26, 2025

gopherbot commented Nov 26, 2025

gopherbot commented Nov 26, 2025

gopherbot commented Nov 26, 2025

gopherbot commented Nov 26, 2025

gopherbot commented Nov 26, 2025

gopherbot commented Nov 26, 2025

gopherbot commented Nov 26, 2025

gopherbot commented Nov 26, 2025

gopherbot commented Nov 26, 2025

gopherbot commented Nov 26, 2025

gopherbot commented Nov 26, 2025

gopherbot commented Nov 26, 2025

gopherbot commented Nov 26, 2025

Labels

2 participants

gavinkflam commented Oct 20, 2025 •

edited

Loading