-
Notifications
You must be signed in to change notification settings - Fork 2.4k
gopls/internal/golang: do not offer "inline variable" on an lvalue reference #590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR (HEAD: 4f937fd) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/701035. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/701035. |
|
Message from Alan Donovan: Patch Set 1: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/701035. |
|
This PR (HEAD: b004dd4) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/701035. Important tips:
|
|
Message from Ilya Ilyinykh: Patch Set 1: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/701035. |
|
Message from Ilya Ilyinykh: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/701035. |
|
This PR (HEAD: bb25652) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/701035. Important tips:
|
|
Message from Ilya Ilyinykh: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/701035. |
|
This PR (HEAD: 8ad209e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/701035. Important tips:
|
|
Message from Ilya Ilyinykh: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/701035. |
|
Message from Alan Donovan: Patch Set 4: (6 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/701035. |
|
This PR (HEAD: d56f591) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/701035. Important tips:
|
|
Message from Ilya Ilyinykh: Patch Set 4: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/701035. |
|
Message from Alan Donovan: Patch Set 5: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/701035. |
|
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-09-10T20:36:32Z","revision":"9d45d87513f1e8ddb2238f2277f6a2d2ea15ca93"} Please don’t reply on this GitHub thread. Visit golang.org/cl/701035. |
|
Message from Alan Donovan: Patch Set 5: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/701035. |
|
Message from Alan Donovan: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/701035. |
|
Message from Alan Donovan: Patch Set 5: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/701035. |
|
Message from Go LUCI: Patch Set 5: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/701035. |
|
Message from Go LUCI: Patch Set 5: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/701035. |
|
This PR (HEAD: 96f0c54) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/701035. Important tips:
|
96f0c54 to
7ddb12c
Compare
|
This PR (HEAD: 7ddb12c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/701035. Important tips:
|
|
Message from Ilya Ilyinykh: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/701035. |
|
Message from t hepudds: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/701035. |
|
Message from Ilya Ilyinykh: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/701035. |
|
Message from Alan Donovan: Patch Set 8: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/701035. |
|
Message from Go LUCI: Patch Set 8: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-09-10T21:55:34Z","revision":"c88a6e1b301650d18d37ed03e8db06a228df1ce8"} Please don’t reply on this GitHub thread. Visit golang.org/cl/701035. |
|
Message from Robert Findley: Patch Set 8: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/701035. |
…ference Fixes golang/go#75200 Change-Id: I30e33a728c27513f759fceb6e3dbd07695aa2498 GitHub-Last-Rev: 7ddb12c GitHub-Pull-Request: #590 Reviewed-on: https://go-review.googlesource.com/c/tools/+/701035 Auto-Submit: Alan Donovan <adonovan@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Alan Donovan <adonovan@google.com> Reviewed-by: Robert Findley <rfindley@google.com>
|
This PR is being closed because golang.org/cl/701035 has been merged. |
Fixes golang/go#75200