Skip to content

Conversation

@andrey-star
Copy link

@andrey-star andrey-star commented Jun 11, 2025

Previously, the MCP client relied on "http.DefaultClient"
which didn't allow for customization.
Here I'm adding an overload that accepts an "http.Client" as parameter.

Fixes golang/go#74108

@gopherbot
Copy link
Contributor

This PR (HEAD: 83ed676) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/681115.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/681115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/681115.
After addressing review feedback, remember to publish your drafts!

@andrey-star andrey-star changed the title Add the ability to provide a custom HTTP client for SSE client connections Jun 12, 2025
@andrey-star andrey-star changed the title x/tools/internal/mcp: Add the ability to provide a custom HTTP client for SSE client connections Jun 12, 2025
@gopherbot
Copy link
Contributor

Message from Andrey Starodubtsev:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/681115.
After addressing review feedback, remember to publish your drafts!

@andrey-star andrey-star changed the title x/tools/internal/mcp: add the ability to provide a custom HTTP client for SSE client connections Jun 17, 2025
@gopherbot
Copy link
Contributor

Message from Robert Findley:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/681115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Andrey Starodubtsev:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/681115.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Findley:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/681115.
After addressing review feedback, remember to publish your drafts!

@andrey-star
Copy link
Author

Closed by 84508c7

@andrey-star andrey-star deleted the mcp-custom-http-client branch June 20, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants