Skip to content

Conversation

@AkihiroSuda
Copy link

@AkihiroSuda AkihiroSuda commented May 27, 2025

When a custom flag.FlagSet is provided, the args should be fetched from that custom FlagSet,
not from the global os.Args.

This fix is useful for calling singlechecker from a CLI subcommand like
gosocialcheck run ./...: AkihiroSuda/gosocialcheck#1

Fixes golang/go#73875

When a custom flag.FlagSet is provided, the args should be fetched from
that custom FlagSet, not from the global os.Args.

This fix is useful for calling singlechecker from a CLI subcommand
like `gosocialcheck run ./...`.

Fixes golang/go#73875

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@gopherbot
Copy link
Contributor

This PR (HEAD: d3b3f2f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/676435.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/676435.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Akihiro Suda:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/676435.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants