Skip to content

Conversation

@seeruk
Copy link

@seeruk seeruk commented Sep 13, 2018

Solves golang/go#27666. I'm not sure if this is the preferred method of implementing something like this, but it does the job!

@gopherbot
Copy link
Contributor

This PR (HEAD: 2f5c307) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/135338 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/135338.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5065:

Patch Set 1:

I think we're waiting on a decision on the GitHub issue first to see what we want to do.

I'm going to wait for a decision there before reviewing code.


Please don’t reply on this GitHub thread. Visit golang.org/cl/135338.
After addressing review feedback, remember to publish your drafts!

@gopherbot gopherbot force-pushed the master branch 2 times, most recently from 9cd7e18 to b917058 Compare October 4, 2019 02:21
@gopherbot gopherbot force-pushed the master branch 8 times, most recently from 8185551 to dc03839 Compare November 5, 2019 20:21
gofera pushed a commit to gofera/tools that referenced this pull request Jan 31, 2020
* commit 'efdb223127a90bc3d95f432fb6022d79f7b1f05d':
  fix notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants