Skip to content

Conversation

@a-h
Copy link

@a-h a-h commented Nov 4, 2022

Fixes #56572

@gopherbot
Copy link
Contributor

This PR (HEAD: 79b5e63) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/448035 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Robert Findley:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/448035.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Alan Donovan:

Patch Set 1:

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/448035.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 952df4b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/448035 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Adrian Hesketh:

Patch Set 2:

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/448035.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Alan Donovan:

Patch Set 2:

(5 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/448035.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 02be885) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/448035 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Adrian Hesketh:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/448035.
After addressing review feedback, remember to publish your drafts!

@a-h a-h force-pushed the issue_56572_go_to_implementation_for_funcs branch from 02be885 to c978bed Compare November 13, 2022 10:30
@gopherbot
Copy link
Contributor

This PR (HEAD: c978bed) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/448035 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Adrian Hesketh:

Patch Set 4:

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/448035.
After addressing review feedback, remember to publish your drafts!

@a-h
Copy link
Author

a-h commented Nov 14, 2022

Hey @gopherbot - how come you haven't picked up the latest commit yet?

@a-h a-h force-pushed the issue_56572_go_to_implementation_for_funcs branch from 405f74b to 1dc58ee Compare November 15, 2022 18:16
@gopherbot
Copy link
Contributor

This PR (HEAD: 1dc58ee) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/448035 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Adrian Hesketh:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/448035.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Alan Donovan:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/448035.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Alan Donovan:

Patch Set 5:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/448035.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Adrian Hesketh:

Patch Set 5:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/448035.
After addressing review feedback, remember to publish your drafts!

@IceflowRE
Copy link

Does it work with generics?

@a-h
Copy link
Author

a-h commented Nov 28, 2023

I took a break from it to try and understand the Go language spec better, because I felt that I didn't fully understand all the points coming back the code review, and now it's out of date. I did think about getting back to this at some point.

There's no generic test case, so this PR might not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants