Skip to content

Conversation

@yaaase
Copy link

@yaaase yaaase commented Jan 15, 2021

As golang has deprecated space-delimited build tags in favor of comma-delimited, this PR allows buildutil.TagsFlag to handle comma-delimited build tags

Fixes golang/go#44787

@google-cla
Copy link

google-cla bot commented Jan 15, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jan 15, 2021
@yaaase yaaase force-pushed the buildutil/tags/comma branch from 07a48bc to fe39683 Compare January 15, 2021 22:32
@google-cla google-cla bot added cla: yes and removed cla: no labels Jan 15, 2021
@yaaase
Copy link
Author

yaaase commented Jan 15, 2021

@googlebot I fixed it.

@gopherbot
Copy link
Contributor

This PR (HEAD: fe39683) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/284214 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/284214.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/284214.
After addressing review feedback, remember to publish your drafts!

@yaaase
Copy link
Author

yaaase commented Mar 4, 2021

Issue created: golang/go#44787

@gopherbot
Copy link
Contributor

Message from Alberto Donizetti:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/284214.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan C. Mills:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/284214.
After addressing review feedback, remember to publish your drafts!

@google-cla
Copy link

google-cla bot commented Mar 5, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Mar 5, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 559d77b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/284214 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants