-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Allow buildutil.TagsFlag to handle comma-delimited tag lists #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
07a48bc to
fe39683
Compare
|
@googlebot I fixed it. |
|
This PR (HEAD: fe39683) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/284214 to see it. Tip: You can toggle comments from me using the |
|
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/284214. |
|
Message from Bryan C. Mills: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/284214. |
|
Issue created: golang/go#44787 |
|
Message from Alberto Donizetti: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/284214. |
|
Message from Bryan C. Mills: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/284214. |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
This PR (HEAD: 559d77b) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/284214 to see it. Tip: You can toggle comments from me using the |
As golang has deprecated space-delimited build tags in favor of comma-delimited, this PR allows buildutil.TagsFlag to handle comma-delimited build tags
Fixes golang/go#44787