Skip to content

Conversation

@jirfag
Copy link
Contributor

@jirfag jirfag commented Sep 11, 2019

Don't load deps by go list if NeedDeps wasn't set. Before that
deps were loading if NeedImports was set.

@gopherbot
Copy link
Contributor

This PR (HEAD: 4a1419d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/194837 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Denis Isaev:

Patch Set 1:

I've made the pull request with reverted in https://go-review.googlesource.com/c/tools/+/186337/ changes


Please don’t reply on this GitHub thread. Visit golang.org/cl/194837.
After addressing review feedback, remember to publish your drafts!

Don't load deps by go list if NeedDeps wasn't set. Before that
deps were loading if NeedImports was set.
@gopherbot
Copy link
Contributor

This PR (HEAD: 016959b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/tools/+/194837 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Michael Matloob:

Patch Set 2:

(2 comments)

Sorry for the slowness to review. I'll have some more comments, but can you sync first? I want to make sure that the CL still makes sense at tip.


Please don’t reply on this GitHub thread. Visit golang.org/cl/194837.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants