-
Notifications
You must be signed in to change notification settings - Fork 189
static/frontend: add a11y attributes to interactive elements #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
static/frontend: add a11y attributes to interactive elements #99
Conversation
Updates interactive elements for unit-meta-details that were previously not accessible via keyboard to have appropriate a11y attributes such as roles, tabindex, and aria-live to improve the overall accessible interactions with the meta- details and make it keyboard and screenreader friendly. Fixes b/#283533035
|
This PR (HEAD: f2cd6cc) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/621396. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/621396. |
|
Message from Jonathan Amsterdam: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/621396. |
|
Message from Jonathan Amsterdam: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/621396. |
|
Message from Jonathan Amsterdam: Patch Set 1: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/621396. |
|
Message from Joy Serquina (xWF): Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/621396. |
|
Message from Joy Serquina (xWF): Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/621396. |
|
Message from Jamal Carvalho: Patch Set 1: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/621396. |
|
Message from Nooras Saba: Patch Set 1: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/621396. |
|
Message from Nooras Saba: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/621396. |
|
Message from Nooras Saba: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/621396. |
|
Message from Jonathan Amsterdam: Patch Set 1: Hold+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/621396. |
|
Message from Joy Serquina (xWF): Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/621396. |
Updates previous fix to add missing end quotation mark. Fixes b/283533035
|
This PR (HEAD: e699df9) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/621396. Important tips:
|
Updates previous fix to generalize the aria-label for the valid/invalid checkbox icon that triggers the tooltip. Fixes b/283533035
|
This PR (HEAD: 3f3fe4f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/621396. Important tips:
|
|
Message from Jonathan Amsterdam: Patch Set 6: Code-Review+2 Commit-Queue+1 Hold+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/621396. |
|
Message from Go LUCI: Patch Set 6: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-12-04T17:18:49Z","revision":"87b80ec87d41153765f887bb81735b2941891e8f"} Please don’t reply on this GitHub thread. Visit golang.org/cl/621396. |
|
Message from kokoro: Patch Set 6: Kokoro presubmit build queued for golang/pkgsite/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/621396. |
|
Message from kokoro: Patch Set 6: Kokoro presubmit build starting for golang/pkgsite/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/621396. |
|
Message from Jonathan Amsterdam: Patch Set 6: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/621396. |
|
Message from Go LUCI: Patch Set 6: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/621396. |
|
Message from Go LUCI: Patch Set 6: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/621396. |
|
Message from Jonathan Amsterdam: Patch Set 6: -Hold Please don’t reply on this GitHub thread. Visit golang.org/cl/621396. |
|
Message from kokoro: Patch Set 6: kokoro-CI+1 Kokoro presubmit build finished with status: SUCCESS Please don’t reply on this GitHub thread. Visit golang.org/cl/621396. |
Updates interactive elements for unit-meta-details that were previously not accessible via keyboard to have appropriate a11y attributes such as roles, tabindex, and aria-live to improve the overall accessible interactions with the meta- details and make it keyboard and screenreader friendly. Before screenshots: -icons: https://screenshot.googleplex.com/4eqbZ7ps58yCWwT -tooltip: https://screenshot.googleplex.com/6qzZ9wdtBpfXszy After: -icon screenshot updates: https://screenshot.googleplex.com/7kbHJk4tYv2naQf -tooltip screenshot updates: https://screenshot.googleplex.com/8ZwutWMTS2FNkwy Fixes b/283533035 Change-Id: I2f08022e4d5c8f504c487ed8dcec2191eaef02e2 GitHub-Last-Rev: 3f3fe4f GitHub-Pull-Request: #99 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/621396 Reviewed-by: Nooras Saba <saba@golang.org> Reviewed-by: Jamal Carvalho <jamalcarvalho@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
|
This PR is being closed because golang.org/cl/621396 has been merged. |
Updates interactive elements for unit-meta-details that were previously not accessible via keyboard to have appropriate a11y attributes such as roles, tabindex, and aria-live to improve the overall accessible interactions with the meta- details and make it keyboard and screenreader friendly. Before screenshots: -icons: https://screenshot.googleplex.com/4eqbZ7ps58yCWwT -tooltip: https://screenshot.googleplex.com/6qzZ9wdtBpfXszy After: -icon screenshot updates: https://screenshot.googleplex.com/7kbHJk4tYv2naQf -tooltip screenshot updates: https://screenshot.googleplex.com/8ZwutWMTS2FNkwy Fixes b/283533035 Change-Id: I2f08022e4d5c8f504c487ed8dcec2191eaef02e2 GitHub-Last-Rev: 3f3fe4f GitHub-Pull-Request: golang#99 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/621396 Reviewed-by: Nooras Saba <saba@golang.org> Reviewed-by: Jamal Carvalho <jamalcarvalho@google.com> kokoro-CI: kokoro <noreply+kokoro@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Updates interactive elements for unit-meta-details that were previously
not accessible via keyboard to have appropriate a11y attributes such as
roles, tabindex, and aria-live to improve the overall accessible
interactions with the meta- details and make it keyboard and
screenreader friendly.
Before screenshots:
-icons:
https://screenshot.googleplex.com/4eqbZ7ps58yCWwT
-tooltip:
https://screenshot.googleplex.com/6qzZ9wdtBpfXszy
After:
-icon screenshot updates:
https://screenshot.googleplex.com/7kbHJk4tYv2naQf
-tooltip screenshot updates:
https://screenshot.googleplex.com/8ZwutWMTS2FNkwy
Fixes b/283533035