Skip to content

Conversation

@essjay05
Copy link
Contributor

@essjay05 essjay05 commented Oct 25, 2024

Updates interactive elements for unit-meta-details that were previously
not accessible via keyboard to have appropriate a11y attributes such as
roles, tabindex, and aria-live to improve the overall accessible
interactions with the meta- details and make it keyboard and
screenreader friendly.

Before screenshots:
-icons:
https://screenshot.googleplex.com/4eqbZ7ps58yCWwT
-tooltip:
https://screenshot.googleplex.com/6qzZ9wdtBpfXszy

After:
-icon screenshot updates:
https://screenshot.googleplex.com/7kbHJk4tYv2naQf
-tooltip screenshot updates:
https://screenshot.googleplex.com/8ZwutWMTS2FNkwy

Fixes b/283533035

Updates interactive elements for unit-meta-details that were
previously not accessible via keyboard to have appropriate
a11y attributes such as roles, tabindex, and aria-live to
improve the overall accessible interactions with the meta-
details and make it keyboard and screenreader friendly.

Fixes b/#283533035
@gopherbot
Copy link
Contributor

This PR (HEAD: f2cd6cc) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/621396.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 1: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Joy Serquina (xWF):

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Joy Serquina (xWF):

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jamal Carvalho:

Patch Set 1: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nooras Saba‎:

Patch Set 1: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nooras Saba‎:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Nooras Saba‎:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 1: Hold+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@essjay05 essjay05 changed the title fix(static/frontend): add a11y attributes to interactive elements Nov 6, 2024
@gopherbot
Copy link
Contributor

Message from Joy Serquina (xWF):

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

Updates previous fix to add missing end quotation
mark.

Fixes b/283533035
@gopherbot
Copy link
Contributor

This PR (HEAD: e699df9) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/621396.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Updates previous fix to generalize the aria-label for
the valid/invalid checkbox icon that triggers the
tooltip.

Fixes b/283533035
@gopherbot
Copy link
Contributor

This PR (HEAD: 3f3fe4f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/621396.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 6: Code-Review+2 Commit-Queue+1 Hold+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-12-04T17:18:49Z","revision":"87b80ec87d41153765f887bb81735b2941891e8f"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 6:

Kokoro presubmit build queued for golang/pkgsite/gcp_ubuntu/presubmit
Logs at: http://sponge2.corp.google.com/0efbd3f7-b507-4474-a8a7-d0d97e0451a0


Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 6:

Kokoro presubmit build starting for golang/pkgsite/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/0efbd3f7-b507-4474-a8a7-d0d97e0451a0


Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 6: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 6:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 6: -Hold


Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 6: kokoro-CI+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/0efbd3f7-b507-4474-a8a7-d0d97e0451a0


Please don’t reply on this GitHub thread. Visit golang.org/cl/621396.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Dec 4, 2024
Updates interactive elements for unit-meta-details that were previously
not accessible via keyboard to have appropriate a11y attributes such as
roles, tabindex, and aria-live to improve the overall accessible
interactions with the meta- details and make it keyboard and
screenreader friendly.

Before screenshots:
-icons:
https://screenshot.googleplex.com/4eqbZ7ps58yCWwT
-tooltip:
https://screenshot.googleplex.com/6qzZ9wdtBpfXszy

After:
-icon screenshot updates:
https://screenshot.googleplex.com/7kbHJk4tYv2naQf
-tooltip screenshot updates:
https://screenshot.googleplex.com/8ZwutWMTS2FNkwy

Fixes b/283533035

Change-Id: I2f08022e4d5c8f504c487ed8dcec2191eaef02e2
GitHub-Last-Rev: 3f3fe4f
GitHub-Pull-Request: #99
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/621396
Reviewed-by: Nooras Saba‎ <saba@golang.org>
Reviewed-by: Jamal Carvalho <jamalcarvalho@google.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/621396 has been merged.

@gopherbot gopherbot closed this Dec 4, 2024
DBowen33 pushed a commit to DBowen33/pkgsite that referenced this pull request Dec 4, 2024
Updates interactive elements for unit-meta-details that were previously
not accessible via keyboard to have appropriate a11y attributes such as
roles, tabindex, and aria-live to improve the overall accessible
interactions with the meta- details and make it keyboard and
screenreader friendly.

Before screenshots:
-icons:
https://screenshot.googleplex.com/4eqbZ7ps58yCWwT
-tooltip:
https://screenshot.googleplex.com/6qzZ9wdtBpfXszy

After:
-icon screenshot updates:
https://screenshot.googleplex.com/7kbHJk4tYv2naQf
-tooltip screenshot updates:
https://screenshot.googleplex.com/8ZwutWMTS2FNkwy

Fixes b/283533035

Change-Id: I2f08022e4d5c8f504c487ed8dcec2191eaef02e2
GitHub-Last-Rev: 3f3fe4f
GitHub-Pull-Request: golang#99
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/621396
Reviewed-by: Nooras Saba‎ <saba@golang.org>
Reviewed-by: Jamal Carvalho <jamalcarvalho@google.com>
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants