-
Notifications
You must be signed in to change notification settings - Fork 189
static/frontend: add Escape key functionality to close tooltip #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
static/frontend: add Escape key functionality to close tooltip #104
Conversation
Updates ToolTipController to have Escape key functionality to close tooltip. Tested successfully. Fixes b/283533035
|
This PR (HEAD: e1cd0ff) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/633804. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/633804. |
|
Message from Jonathan Amsterdam: Patch Set 1: Code-Review+1 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/633804. |
|
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-12-09T21:34:02Z","revision":"611cc78e15f1676cb9982b2a3dc1369791491cd5"} Please don’t reply on this GitHub thread. Visit golang.org/cl/633804. |
|
Message from kokoro: Patch Set 1: Kokoro presubmit build queued for golang/pkgsite/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/633804. |
|
Message from kokoro: Patch Set 1: Kokoro presubmit build starting for golang/pkgsite/gcp_ubuntu/presubmit Please don’t reply on this GitHub thread. Visit golang.org/cl/633804. |
|
Message from kokoro: Patch Set 1: kokoro-CI-1 Kokoro presubmit build finished with status: FAILURE Please don’t reply on this GitHub thread. Visit golang.org/cl/633804. |
|
Message from Jonathan Amsterdam: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/633804. |
|
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/633804. |
|
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/633804. |
Updates to remove lint error.
|
Message from Joy Serquina (xWF): Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/633804. |
|
This PR (HEAD: 5c4b386) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/633804. Important tips:
|
|
Message from Jonathan Amsterdam: Patch Set 3: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/633804. |
|
Message from Jonathan Amsterdam: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/633804. |
|
Message from Jonathan Amsterdam: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/633804. |
|
Message from Jonathan Amsterdam: Patch Set 3: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/633804. |
|
Message from Gopher Robot: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/633804. |
|
Message from Jonathan Amsterdam: Patch Set 3: TryBot-Bypass+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/633804. |
|
Message from Jonathan Amsterdam: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/633804. |
|
Message from Jonathan Amsterdam: Patch Set 3: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/633804. |
|
Message from Gopher Robot: Patch Set 3: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/633804. |
|
Message from Joy Serquina (xWF): Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/633804. |
frontend: adds escape key action to close tooltip Updates ToolTipController to have Escape key functionality to close tooltip. Tested successfully. Screencast: https://screencast.googleplex.com/cast/NjA0MjM5NjE3NjQxNjc2OHwwYmI3ZGMyZC1jZQ Fixes internal bug where Escape key needs to close tooltips/dialogs b/283533035 Change-Id: I8abe107080b262b989c529ef79c0bb2fcc7a6d32 GitHub-Last-Rev: 5c4b386 GitHub-Pull-Request: #104 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/633804 TryBot-Bypass: Jonathan Amsterdam <jba@google.com> Reviewed-by: Nooras Saba <noorassaba@google.com> Run-TryBot: Jonathan Amsterdam <jba@google.com> Reviewed-by: Jonathan Amsterdam <jba@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
|
Message from Nooras Saba: Patch Set 3: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/633804. |
|
This PR is being closed because golang.org/cl/633804 has been merged. |
frontend: adds escape key action to close tooltip
Updates ToolTipController to have Escape key functionality
to close tooltip. Tested successfully.
Screencast: https://screencast.googleplex.com/cast/NjA0MjM5NjE3NjQxNjc2OHwwYmI3ZGMyZC1jZQ
Fixes internal bug where Escape key needs to close tooltips/dialogs b/283533035