Skip to content

Conversation

@essjay05
Copy link
Contributor

@essjay05 essjay05 commented Dec 9, 2024

frontend: adds escape key action to close tooltip

Updates ToolTipController to have Escape key functionality
to close tooltip. Tested successfully.

Screencast: https://screencast.googleplex.com/cast/NjA0MjM5NjE3NjQxNjc2OHwwYmI3ZGMyZC1jZQ

Fixes internal bug where Escape key needs to close tooltips/dialogs b/283533035

Updates ToolTipController to have Escape key functionality to
close tooltip. Tested successfully.

Fixes b/283533035
@gopherbot
Copy link
Contributor

This PR (HEAD: e1cd0ff) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/633804.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/633804.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 1: Code-Review+1 Commit-Queue+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/633804.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-12-09T21:34:02Z","revision":"611cc78e15f1676cb9982b2a3dc1369791491cd5"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/633804.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 1:

Kokoro presubmit build queued for golang/pkgsite/gcp_ubuntu/presubmit
Logs at: http://sponge2.corp.google.com/b5a885a2-9233-41e8-b839-096e3fa7e17d


Please don’t reply on this GitHub thread. Visit golang.org/cl/633804.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 1:

Kokoro presubmit build starting for golang/pkgsite/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/b5a885a2-9233-41e8-b839-096e3fa7e17d


Please don’t reply on this GitHub thread. Visit golang.org/cl/633804.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from kokoro:

Patch Set 1: kokoro-CI-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/b5a885a2-9233-41e8-b839-096e3fa7e17d


Please don’t reply on this GitHub thread. Visit golang.org/cl/633804.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 1: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/633804.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/633804.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/633804.
After addressing review feedback, remember to publish your drafts!

Updates to remove lint error.
@gopherbot
Copy link
Contributor

Message from Joy Serquina (xWF):

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/633804.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 5c4b386) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/633804.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 3: Code-Review+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/633804.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 3:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/633804.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/633804.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 3: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/633804.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/633804.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 3: TryBot-Bypass+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/633804.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/633804.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 3: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/633804.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 3: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/633804.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Joy Serquina (xWF):

Patch Set 3:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/633804.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Dec 10, 2024
frontend: adds escape key action to close tooltip

Updates ToolTipController to have Escape key functionality
to close tooltip. Tested successfully.

Screencast: https://screencast.googleplex.com/cast/NjA0MjM5NjE3NjQxNjc2OHwwYmI3ZGMyZC1jZQ

Fixes internal bug where Escape key needs to close tooltips/dialogs b/283533035

Change-Id: I8abe107080b262b989c529ef79c0bb2fcc7a6d32
GitHub-Last-Rev: 5c4b386
GitHub-Pull-Request: #104
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/633804
TryBot-Bypass: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Nooras Saba‎ <noorassaba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@gopherbot
Copy link
Contributor

Message from Nooras Saba‎:

Patch Set 3: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/633804.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/633804 has been merged.

@gopherbot gopherbot closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants