Skip to content

static/frontend: add search aria-describedby #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
essjay05 wants to merge 1 commit into from
Closed

static/frontend: add search aria-describedby #102

essjay05 wants to merge 1 commit into from

Conversation

@essjay05
Copy link
Contributor

@essjay05 essjay05 commented Nov 5, 2024 •
edited
Loading

Currently the search input aria-label is static and when
focused on by a screen reader, the screen reader does
not read the search tip found below the input. This
change checks the .TipIndex value and if it
matches adds the id=SearchTipContent which the input's
aria-describedby is attached to, thus allowing the visible
tip/description to be read as supplemental info after the
input's existing aria-label.

Before screenshot:
https://screenshot.googleplex.com/AkAmQ69s4R3NsZS

After screenshot:
https://screenshot.googleplex.com/94MwK6bXpSBE6Gr

Fixes b/283297190
@essjay05
fix(static/frontend): add search aria-describedby
2ebbcc3 
Currently the search input aria-label is static and
when focused on by a screen reader, the screen reader
does not read the search tip found below the input.
This change checks the .TipIndex value and if it
matches adds the id=SearchTipContent which the input's
aria-describedby is attached to, thus allowing the
visible tip/description to be read as supplemental
info after the input's existing aria-label.

Fixes b/#283297190
@gopherbot
Copy link
Contributor

gopherbot commented Nov 5, 2024

This PR (HEAD: 2ebbcc3) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/pkgsite/+/625235.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

gopherbot commented Nov 5, 2024

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Nov 5, 2024

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Nov 5, 2024

Message from Joy Serquina (xWF):

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Nov 6, 2024

Message from Jonathan Amsterdam:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Nov 6, 2024

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@essjay05 essjay05 changed the title fix(static/frontend): add search aria-describedby Nov 6, 2024
@gopherbot
Copy link
Contributor

gopherbot commented Nov 7, 2024

Message from Joy Serquina (xWF):

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Dec 4, 2024

Message from Jonathan Amsterdam:

Patch Set 3: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Dec 4, 2024

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-12-04T14:56:14Z","revision":"2430f3fade26fdd0f2a8fd2d1ee74f1b1c643dd0"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Dec 4, 2024

Message from kokoro:

Patch Set 3:

Kokoro presubmit build queued for golang/pkgsite/gcp_ubuntu/presubmit
Logs at: http://sponge2.corp.google.com/81272f5c-8b6b-4f7f-9aa3-e716d064f599

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Dec 4, 2024

Message from kokoro:

Patch Set 3:

Kokoro presubmit build starting for golang/pkgsite/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/81272f5c-8b6b-4f7f-9aa3-e716d064f599

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Dec 4, 2024

Message from Jonathan Amsterdam:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Dec 4, 2024

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Dec 4, 2024

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Dec 4, 2024

Message from Denis Bowen (xWF):

Patch Set 3: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Dec 4, 2024

Message from kokoro:

Patch Set 3: kokoro-CI-1

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/81272f5c-8b6b-4f7f-9aa3-e716d064f599

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Dec 4, 2024

Message from Jonathan Amsterdam:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Dec 4, 2024

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-12-04T15:44:17Z","revision":"2430f3fade26fdd0f2a8fd2d1ee74f1b1c643dd0"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Dec 4, 2024

Message from Jonathan Amsterdam:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Dec 4, 2024

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Dec 4, 2024

Message from Jonathan Amsterdam:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Dec 4, 2024

Message from kokoro:

Patch Set 3:

Kokoro presubmit build starting for golang/pkgsite/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/def3341e-1694-4b5f-96ca-2c0174753342

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Dec 4, 2024

Message from kokoro:

Patch Set 3:

Kokoro presubmit build finished with status: FAILURE
Logs at: https://source.cloud.google.com/results/invocations/def3341e-1694-4b5f-96ca-2c0174753342

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Dec 4, 2024

Message from Jonathan Amsterdam:

Patch Set 4: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Dec 4, 2024

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-12-04T16:50:30Z","revision":"78889042959b1813de9247d0d0bc941acd072f32"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Dec 4, 2024

Message from kokoro:

Patch Set 4:

Kokoro presubmit build queued for golang/pkgsite/gcp_ubuntu/presubmit
Logs at: http://sponge2.corp.google.com/b69644cf-c927-4c0e-b819-c86bf5a5a944

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Dec 4, 2024

Message from kokoro:

Patch Set 4:

Kokoro presubmit build starting for golang/pkgsite/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/b69644cf-c927-4c0e-b819-c86bf5a5a944

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Dec 4, 2024

Message from Jonathan Amsterdam:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Dec 4, 2024

Message from Go LUCI:

Patch Set 4:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Dec 4, 2024

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/625235.
After addressing review feedback, remember to publish your drafts!
gopherbot pushed a commit that referenced this pull request Dec 4, 2024
@essjay05 @jba
static/frontend: add search aria-describedby
75bf08d 
Currently the search input aria-label is static and when
focused on by a screen reader, the screen reader does
not read the search tip found below the input. This
change checks the .TipIndex value and if it
matches adds the id=SearchTipContent which the input's
aria-describedby is attached to, thus allowing the visible
tip/description to be read as supplemental info after the
input's existing aria-label.

Before screenshot:
https://screenshot.googleplex.com/AkAmQ69s4R3NsZS

After screenshot:
https://screenshot.googleplex.com/94MwK6bXpSBE6Gr

Fixes b/283297190

Change-Id: I4363f226673c9da1abcfced38088398a5f7a5b2e
GitHub-Last-Rev: 2ebbcc3
GitHub-Pull-Request: #102
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/625235
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Denis Bowen (xWF) <denisbowen@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@gopherbot
Copy link
Contributor

gopherbot commented Dec 4, 2024

This PR is being closed because golang.org/cl/625235 has been merged.
@gopherbot gopherbot closed this Dec 4, 2024
DBowen33 pushed a commit to DBowen33/pkgsite that referenced this pull request Dec 4, 2024
@essjay05 @DBowen33
static/frontend: add search aria-describedby
a8417f4 
Currently the search input aria-label is static and when
focused on by a screen reader, the screen reader does
not read the search tip found below the input. This
change checks the .TipIndex value and if it
matches adds the id=SearchTipContent which the input's
aria-describedby is attached to, thus allowing the visible
tip/description to be read as supplemental info after the
input's existing aria-label.

Before screenshot:
https://screenshot.googleplex.com/AkAmQ69s4R3NsZS

After screenshot:
https://screenshot.googleplex.com/94MwK6bXpSBE6Gr

Fixes b/283297190

Change-Id: I4363f226673c9da1abcfced38088398a5f7a5b2e
GitHub-Last-Rev: 2ebbcc3
GitHub-Pull-Request: golang#102
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/625235
kokoro-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Denis Bowen (xWF) <denisbowen@google.com>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@essjay05 @gopherbot