Skip to content

proxy: expand Dialer interface to expose DialContext #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sjpotter wants to merge 1 commit into
base: master
Choose a base branch
from
Open

proxy: expand Dialer interface to expose DialContext #164

sjpotter wants to merge 1 commit into from
+7 −0

Conversation

@sjpotter
Copy link

@sjpotter sjpotter commented Feb 6, 2023

currently, the Dialer interface returned (from say proxy.SOCKS5()) only exposes the Dial function, while it has a DialContext function as well. As Dial() usage is deprecated, DialContext should be exposed as well.

All implementations in proxy already had a DialContext function besides a single test recording struct, so added a similiar recorder to it.
@sjpotter
proxy: expand Dialer interface to expose DialContext
9178fd7 
currently, the Dialer interface returned (from say proxy.SOCKS5()) only exposes the Dial function, while it has a DialContext function as well.  As Dial() usage is deprecated, DialContext should be exposed as well.

All implementations in proxy already had a DialContext function besides a single test recording struct, so added a similiar recorder to it.
@gopherbot
Copy link
Contributor

gopherbot commented Feb 6, 2023

This PR (HEAD: 9178fd7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/465495 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
@gopherbot
Copy link
Contributor

gopherbot commented Feb 7, 2023

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/465495.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Feb 7, 2023

Message from Shaya Potter:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/465495.
After addressing review feedback, remember to publish your drafts!
@sjpotter sjpotter mentioned this pull request Feb 7, 2023
Open
@gopherbot
Copy link
Contributor

gopherbot commented Feb 7, 2023

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/465495.
After addressing review feedback, remember to publish your drafts!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@sjpotter @gopherbot