-
Notifications
You must be signed in to change notification settings - Fork 18.7k
bytes: improve consistency in split test messages #76970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
This PR (HEAD: 8c4a351) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/732300. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/732300. |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/732300. |
|
Message from Jorge Pinto: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/732300. |
|
Message from Jorropo: Patch Set 3: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/732300. |
|
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-12-23T18:44:58Z","revision":"4e7fd367d5ed7b854f4971af92fb00a500b0c494"} Please don’t reply on this GitHub thread. Visit golang.org/cl/732300. |
|
Message from Jorropo: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/732300. |
|
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/732300. |
|
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/732300. |
|
Message from Michael Knyszek: Patch Set 3: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/732300. |
This change improves consistency in the error messages used by TestSplit and TestSplitAfter in bytes_test.go Change-Id: Idc4e77a516037ce17cbb1bdffe3ac00bcde5de42 GitHub-Last-Rev: 8c4a351 GitHub-Pull-Request: #76970 Reviewed-on: https://go-review.googlesource.com/c/go/+/732300 Reviewed-by: Michael Knyszek <mknyszek@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Jorropo <jorropo.pgm@gmail.com> Auto-Submit: Jorropo <jorropo.pgm@gmail.com>
|
Message from Dmitri Shuralyov: Patch Set 3: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/732300. |
|
This PR is being closed because golang.org/cl/732300 has been merged. |
This change improves consistency in the error messages used by TestSplit and TestSplitAfter in bytes_test.go