-
Notifications
You must be signed in to change notification settings - Fork 18.7k
runtime: revert entry point on freebsd/arm64 #76959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR (HEAD: 6fd243e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/731980. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/731980. |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/731980. |
|
Message from Austin Clements: Patch Set 1: Code-Review+2 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/731980. |
|
Message from Austin Clements: Patch Set 1: Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/731980. |
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/731980. |
|
Message from Gopher Robot: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/731980. |
|
Message from Robert Nichols: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/731980. |
|
Message from Cherry Mui: Patch Set 1: Code-Review+2 Copied votes on follow-up patch sets have been updated:
(1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/731980. |
|
This PR (HEAD: 70064d8) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/731980. Important tips:
|
|
Message from Robert Nichols: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/731980. |
|
Message from Ian Lance Taylor: Patch Set 3: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/731980. |
|
Message from Cherry Mui: Patch Set 3: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/731980. |
|
Message from Austin Clements: Patch Set 3: Auto-Submit+1 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/731980. |
|
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-12-22T23:17:58Z","revision":"c2c4bcc39716f399037305663d81dfa7c9674db1"} Please don’t reply on this GitHub thread. Visit golang.org/cl/731980. |
|
Message from Austin Clements: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/731980. |
|
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/731980. |
|
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/731980. |
CL 706175 unified some arm64 entry points. However, the entry point for freebsd/arm64 is incorrect and builds now fail. This change reverts the freebsd/arm64 entry point and adds additional context for the future. Fixes #76958 Change-Id: Ib9e9b7844706f7b0ef54bd449411fefc8f10bc43 GitHub-Last-Rev: 70064d8 GitHub-Pull-Request: #76959 Reviewed-on: https://go-review.googlesource.com/c/go/+/731980 Auto-Submit: Austin Clements <austin@google.com> Reviewed-by: Ian Lance Taylor <iant@golang.org> Reviewed-by: Austin Clements <austin@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
|
This PR is being closed because golang.org/cl/731980 has been merged. |
CL 706175 unified some arm64 entry points. However, the entry point for
freebsd/arm64 is incorrect and builds now fail. This change reverts the
freebsd/arm64 entry point and adds additional context for the future.
Fixes #76958