reflect: optimize DeepEqual for slice types #64798

qiulaidongfeng · 2023-12-19T12:00:52Z

DeepEqual optimize for some types
by comparing two instances of the same type by comparing the raw memory contents

goos: windows
goarch: amd64
pkg: reflect
cpu: AMD Ryzen │ old.txt │ │ sec/op DeepEqual/[]int8-16 DeepEqual/[]int16-16 DeepEqual/[]int32-16 DeepEqual/[]int64-16 DeepEqual/[]int-16 DeepEqual/[]uint8-16 DeepEqual/[]uint16-16 DeepEqual/[]uint32-16 DeepEqual/[]uint64-16 DeepEqual/[]uint-16 DeepEqual/[]uintptr-16 DeepEqual/[]float32-16 DeepEqual/[]float64-16 DeepEqual/[]complex64-16 DeepEqual/[]complex128-16 DeepEqual/[]bool-16 DeepEqual/[]string-16 DeepEqual/[]uint8#01-16 DeepEqual/[][]uint8-16 DeepEqual/[6]uint8-16 DeepEqual/[][6]uint8-16 DeepEqual/[]int16#01-16 geomean 7 7840HS w/ Radeon 780M Graphics
new.txt │
│ sec/op vs base │
55.33n ± 2% 46.89n ± 1% -15.26% (p=0.000 n=10)
55.55n ± 3% 46.86n ± 2% -15.65% (p=0.000 n=10)
56.11n ± 1% 46.66n ± 1% -16.83% (p=0.000 n=10)
55.91n ± 2% 46.62n ± 1% -16.62% (p=0.000 n=10)
55.58n ± 1% 46.86n ± 1% -15.70% (p=0.000 n=10)
49.30n ± 3% 46.71n ± 1% -5.26% (p=0.000 n=10)
55.90n ± 1% 46.81n ± 1% -16.26% (p=0.000 n=10)
55.33n ± 4% 46.93n ± 1% -15.20% (p=0.000 n=10)
55.77n ± 1% 46.92n ± 1% -15.87% (p=0.000 n=10)
55.52n ± 3% 46.86n ± 5% -15.60% (p=0.000 n=10)
55.68n ± 2% 46.73n ± 2% -16.08% (p=0.000 n=10)
55.30n ± 2% 53.16n ± 2% -3.88% (p=0.000 n=10)
55.82n ± 1% 53.23n ± 2% -4.65% (p=0.000 n=10)
55.51n ± 2% 53.73n ± 1% -3.21% (p=0.000 n=10)
55.62n ± 3% 53.50n ± 2% -3.81% (p=0.000 n=10)
55.56n ± 3% 47.16n ± 1% -15.13% (p=0.000 n=10)
56.12n ± 3% 53.38n ± 2% -4.88% (p=0.000 n=10)
49.73n ± 3% 46.76n ± 2% -5.97% (p=0.000 n=10)
92.81n ± 1% 89.34n ± 2% -3.73% (p=0.000 n=10)
76.88n ± 1% 74.58n ± 1% -3.00% (p=0.000 n=10)
117.25n ± 1% 47.09n ± 2% -59.83% (p=0.000 n=10)
91562.5n ± 2% 322.4n ± 2% -99.65% (p=0.000 n=10)
82.85n 55.41n -33.12%

gopherbot · 2023-12-19T12:08:17Z

This PR (HEAD: a58782e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/551175.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-12-19T12:14:58Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-19T13:01:42Z

This PR (HEAD: a4ad968) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/551175.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-12-20T11:12:57Z

Message from qiulaidongfeng:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-20T17:13:08Z

Message from Keith Randall:

Patch Set 4:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-22T12:37:03Z

This PR (HEAD: c6199a8) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/551175.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-12-22T12:50:09Z

Message from qiulaidongfeng:

Patch Set 5: Run-TryBot+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-22T12:50:19Z

This PR (HEAD: 1388942) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/551175.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2023-12-22T12:56:52Z

Message from Gopher Robot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-22T12:56:52Z

Message from Gopher Robot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-22T12:56:53Z

Message from Gopher Robot:

Patch Set 5: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-22T12:56:54Z

Message from qiulaidongfeng:

Patch Set 6: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-22T13:03:26Z

Message from Gopher Robot:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-22T13:16:41Z

Message from Gopher Robot:

Patch Set 6: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2023-12-22T13:23:08Z

Message from qiulaidongfeng:

Patch Set 6: -Run-TryBot

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-06T08:41:41Z

Message from qiulaidongfeng:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-09T00:07:34Z

Message from Keith Randall:

Patch Set 6:

(10 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-09T10:30:25Z

This PR (HEAD: 4f7812e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/551175.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-09T10:44:51Z

Message from qiulaidongfeng:

Patch Set 7: Run-TryBot+1

(8 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-09T10:44:52Z

Message from Gopher Robot:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-09T10:58:46Z

Message from Gopher Robot:

Patch Set 7: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-09T11:20:19Z

Message from qiulaidongfeng:

Patch Set 7: -Run-TryBot

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-10T18:11:48Z

Message from Keith Randall:

Patch Set 7:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-11T08:56:29Z

This PR (HEAD: 94c2172) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/551175.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-11T09:17:30Z

Message from qiulaidongfeng:

Patch Set 8: Run-TryBot+1

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-11T09:17:31Z

Message from Gopher Robot:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-11T09:24:31Z

Message from Gopher Robot:

Patch Set 8: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-11T09:24:31Z

Message from qiulaidongfeng:

Patch Set 8: -Run-TryBot

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-11T17:09:18Z

Message from Keith Randall:

Patch Set 8:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-11T19:30:58Z

Message from Cherry Mui:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-12T07:37:43Z

Message from qiulaidongfeng:

Patch Set 8:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-12T16:41:30Z

Message from Cherry Mui:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-16T13:31:21Z

Message from qiulaidongfeng:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

Change-Id: Iba1b710707114ba0b4358b8f01f083e2dca8f68d

gopherbot · 2024-01-23T05:14:24Z

This PR (HEAD: ff903bb) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/551175.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-23T05:27:44Z

Message from qiulaidongfeng:

Patch Set 9: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-23T05:27:45Z

Message from Gopher Robot:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-23T05:41:02Z

Message from Gopher Robot:

Patch Set 9: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-23T05:41:03Z

Message from qiulaidongfeng:

Patch Set 9: -Run-TryBot

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-29T13:43:53Z

Message from qiulaidongfeng:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-29T16:40:32Z

Message from Cherry Mui:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-30T02:43:53Z

Message from qiulaidongfeng:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-01T13:56:22Z

Message from qiulaidongfeng:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551175.
After addressing review feedback, remember to publish your drafts!

qiulaidongfeng changed the title ~~reflect: optimize DeepEqual for slice typs~~ Dec 19, 2023

qiulaidongfeng force-pushed the reflect-deeepequal-slice branch from 4f7812e to 94c2172 Compare January 11, 2024 08:52

qiulaidongfeng added 7 commits January 23, 2024 10:36

add benchmark

52006fa

optimize deepequal for slice typs

662f585

fix

8ae102a

fix2

3fb5ab2

fix3

1455d70

fix4

80ad3ba

fix5

5bc9e46

qiulaidongfeng force-pushed the reflect-deeepequal-slice branch from 94c2172 to 5bc9e46 Compare January 23, 2024 05:08

add test for struct

ff903bb

Change-Id: Iba1b710707114ba0b4358b8f01f083e2dca8f68d

reflect: optimize DeepEqual for slice types #64798

Are you sure you want to change the base?

reflect: optimize DeepEqual for slice types #64798

Conversation

qiulaidongfeng commented Dec 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

gopherbot commented Dec 19, 2023

gopherbot commented Dec 19, 2023

gopherbot commented Dec 19, 2023

gopherbot commented Dec 20, 2023

gopherbot commented Dec 20, 2023

gopherbot commented Dec 22, 2023

gopherbot commented Dec 22, 2023

gopherbot commented Dec 22, 2023

gopherbot commented Dec 22, 2023

gopherbot commented Dec 22, 2023

gopherbot commented Dec 22, 2023

gopherbot commented Dec 22, 2023

gopherbot commented Dec 22, 2023

gopherbot commented Dec 22, 2023

gopherbot commented Dec 22, 2023

gopherbot commented Jan 6, 2024

gopherbot commented Jan 9, 2024

gopherbot commented Jan 9, 2024

gopherbot commented Jan 9, 2024

gopherbot commented Jan 9, 2024

gopherbot commented Jan 9, 2024

gopherbot commented Jan 9, 2024

gopherbot commented Jan 10, 2024

gopherbot commented Jan 11, 2024

gopherbot commented Jan 11, 2024

gopherbot commented Jan 11, 2024

gopherbot commented Jan 11, 2024

gopherbot commented Jan 11, 2024

gopherbot commented Jan 11, 2024

gopherbot commented Jan 11, 2024

gopherbot commented Jan 12, 2024

gopherbot commented Jan 12, 2024

gopherbot commented Jan 16, 2024

gopherbot commented Jan 23, 2024

gopherbot commented Jan 23, 2024

gopherbot commented Jan 23, 2024

gopherbot commented Jan 23, 2024

gopherbot commented Jan 23, 2024

gopherbot commented Jan 29, 2024

gopherbot commented Jan 29, 2024

gopherbot commented Jan 30, 2024

gopherbot commented Feb 1, 2024

Labels

2 participants

qiulaidongfeng commented Dec 19, 2023 •

edited

Loading